Skip to content

Conversation

@ijklam
Copy link
Contributor

@ijklam ijklam commented Dec 7, 2025

Make semantic token mapping more accurate. And add a new modifier "Extension" to make user can make themes that can distinguish extension methods out from intrinsic methods.
See ionide/ionide-vscode-fsharp#2114

Basically, changes are:

  1. ReferenceType → Class
  2. MutableVar → Variable + Mutable
  3. MutableRecordField → Property + Mutable
  4. UnionCaseField → Parameter
  5. Method → Method (not Function)
  6. ExtensionMethod → Method + Extension

@baronfel
Copy link
Contributor

baronfel commented Dec 7, 2025

Independent of any actual theme changes, it's always lovely to have more precise scopes! Thanks for taking the time to dig into this area.

Copy link
Member

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@TheAngryByrd TheAngryByrd merged commit 3380fbe into ionide:main Dec 7, 2025
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants