Update watcher.fsx to support nullness #2055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have zero experience on the Ionide codebase, but saw that VSCode was giving nullness warnings on starting FSI e.g. ``` ionide.ionide-fsharp-7.22.0\watcher\watcher.fsx(48,34): warning FS3261: Nullness warning: The types 'System.Reflection.MemberInfo' and 'System.Reflection.MemberInfo | null' do not have compatible nullability. ``` This PR removes the warnings, but someone should review them to make sure that there hasn't been any semantic change in behaviour.
baronfel
approved these changes
Dec 6, 2024
Contributor
|
Thanks @isaacabraham! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have zero experience on the Ionide codebase, but saw that VSCode was giving nullness warnings on starting FSI e.g.
This PR removes the warnings, but someone should review them to make sure that there hasn't been any semantic change in behaviour.
I also saw one apparently unnecessary transformation from Array to List to Seq which I have removed, for performance purposes.