You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request fixes the issue with line number positioning when using the “Send File” command in Ionide’s FSI (related to #2064). By introducing an optional overrideLine: int option parameter in the sendCd function, it ensures that a custom line number can be used when necessary, correcting any potential misalignment issues when sending files to the F# Interactive.
If overrideLine is not provided, it retains the original logic (using the line after the editor’s current selection). Otherwise, it uses the provided line number.
Call Site Updates
All original calls like sendCd terminal (Some editor) are replaced accordingly, passing either None or Some <line> when needed, for example:
This allows flexible line number specification for scenarios like “Send File.”
Effects
Issue with Sending Files Resolved
By explicitly overriding the line number, Ionide ensures that commands like “Send File” start executing from line 1, preventing unexpected behavior at the top of the file or at specific lines.
Backward Compatibility Preserved
If no overrideLine is provided, it continues using the selected line from the editor, so there’s no need to change existing usage patterns.
This change allows Ionide to have better control over line numbers when sending scripts or snippets to FSI, resolving user-reported issues where the wrong line was being executed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.