Skip to content

Fix tests disappearing from the explorer when their file is edited #2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheAngryByrd merged 1 commit into from
Aug 19, 2025
+2 −9
Merged

Fix tests disappearing from the explorer when their file is edited #2098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions src/Components/TestExplorer.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,7 +1032,6 @@ module TestDiscovery =
(targetCollection: TestItemCollection)
(previousCodeTests: TestItem array)
(newCodeTests: TestItem array)
(isKnownDisplacedFragment: CodeBasedTestId -> bool)
=
let rangeComparable (maybeRange: Vscode.Range option) =
let positionComparable (p: Vscode.Position) = $"{p.line}:{p.character}"
Expand All @@ -1053,9 +1052,7 @@ module TestDiscovery =

removed |> Array.map TestItem.getId |> Array.iter targetCollection.delete

added
|> Array.filter (TestItem.getId >> isKnownDisplacedFragment)
|> Array.iter targetCollection.add
added |> Array.iter targetCollection.add

unchanged
|> Array.iter (fun (previousCodeTest, newCodeTest) ->
Expand Down Expand Up @@ -1768,11 +1765,7 @@ module Interactions =
match cached with
| None -> ()
| Some previousTestsFromSameCode ->
TestDiscovery.mergeCodeUpdates
rootTestCollection
previousTestsFromSameCode
testsFromCode
displacedFragmentMapCache.ContainsKey
TestDiscovery.mergeCodeUpdates rootTestCollection previousTestsFromSameCode testsFromCode

testsPerFileCache[filePath] <- testsFromCode

Expand Down
Loading