-
-
Notifications
You must be signed in to change notification settings - Fork 295
implements file type filtering for Explorer (#2103) #2104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you attach a screenshot so we can all go "oooh" and "ahhh" over your changes? |
|
@TheAngryByrd @baronfel I add extra fix to make sure that it takes everything similar to the vs code explorer. Now it shows the .deps folder which contains the fsy and fsl files, if other folder needs to be added that, we could just change the |
|
Awesome work! How does the right click menu look/work for non f# files? |
|
@TheAngryByrd It works the same as the |
|
Do those actions still work appropriately? I know we do xml manipulation on the server side for the project file which could have some weird side effects. |
|
@TheAngryByrd the .deps folder is actually a generated folder, so it doesnt actually work..do you suggest anything? |
|
We may need to apply the right click menu to files (and possibly only f# files). I'm not as familiar with this part of the code though so I don't have any immediate guidance on how to do it in the code. |
|
So, what I have observed is that the .deps folder is created to cache project system and is generated by Ionide when you open the project. This is not technically required to be shown since its generated, but since VS code shows it, we have this fix to show it. |
|
Yeah I think we can do that kind of stuff in a separate PR as long as the right-click menu doesn't damage somebody's project file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements comprehensive file type filtering for the Solution Explorer, expanding the view beyond just compiled source files to include all project items like Content, EmbeddedResource, FsLex, and FsYacc files. The change removes the restrictive "Compile" filter that was hiding non-source files and replaces it with smart filtering and file type mapping.
- Removed hard-coded "Compile" filter that was hiding all non-source files
- Added file extension to item type mapping for comprehensive file categorization
- Enhanced project and solution exploration to include additional folders (bin, obj, packages, etc.)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Looks good now! Did a thorough check, asked Copilot as well to check the PR. |
TheAngryByrd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!


Implemented file type filtering in Solution Explorer, allowing viewing of all project items (including Content, None, EmbeddedResource, FsLex and FsYacc files).
Changes: