Fix xUnit test name parsing with floating point parameters#2127
Draft
Fix xUnit test name parsing with floating point parameters#2127
Conversation
Co-authored-by: TheAngryByrd <1490044+TheAngryByrd@users.noreply.github.com>
Co-authored-by: TheAngryByrd <1490044+TheAngryByrd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix incorrect test names in xUnit Test Explorer
Fix xUnit test name parsing with floating point parameters
Feb 11, 2026
This was referenced Feb 22, 2026
github-actions bot
added a commit
that referenced
this pull request
Mar 19, 2026
…TypeCheck build target - In ArrayExt.venn, add Array.distinctBy guards before building the ID maps to prevent 'An item with the same key has already been added' exceptions when xUnit MemberData theory tests produce duplicate IDs (Closes #2126, works alongside PR #2127) - In TestItemDTO.getFullname_withNestedParamTests for XUnit, replace the Split('.') |> Array.last approach with Substring(FullName.Length). This correctly handles float parameters like 0.5 in InlineData and parameter records in MemberData that contain dots in their ToString output. - Add a TypeCheck FAKE target to build/Program.fs that runs Fable compilation only (no webpack bundling), providing faster type-checking feedback in development and CI scenarios. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xUnit tests with
InlineDatacontaining floating point numbers display garbled names in Test Explorer (e.g.,"25)"instead of"(multiplicand: 0.5, multiplier: 0.5, expectedValue: 0.25)").Root Cause
The DisplayName parser splits on
.to extract theory case parameters:This incorrectly splits on decimal points in float values. For DisplayName:
The split produces:
["MyModule"; "multiply"; "Test(multiplicand: 0"; "5, multiplier: 0"; "5, expectedValue: 0"; "25)"]Taking the last element yields
"25)".Changes
Substringafter removing FullName prefixOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.