Add PackageReferences to nuget packages #215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smaug123
commented
Oct 4, 2024
|
|
||
| let packageReferences = | ||
| p.Items | ||
| |> Seq.filter (fun p -> p.ItemType = "PackageReference") |
There was a problem hiding this comment.
Shout if you would like to commonise this. For example, I could Seq.choose into a Choice1Of2 and Choice2Of2 and then match on that to decide whether to use EvaluatedInclude or NuGetPackageId. I've raised an alternative phrasing at #216 if you would prefer to take that PR instead.
|
Gonna go with the other PR which is cleaner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we are currently simply missing all
PackageReferences?There's no corresponding
NuGetPackageIdon aPackageReference, so I've gone with simply obtaining theIncludevalue.The whitespace changes earlier in the file are the result of
dotnet fantomas ..