Fix slow graph binlog #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAngryByrd
force-pushed
the
fix-slow-graph-binlog
branch
from
df04b20 to
6ee4aca
Compare
baronfel
approved these changes
Feb 18, 2025
TheAngryByrd
commented
Feb 18, 2025
| @@ -1224,7 +1214,7 @@ type WorkspaceLoaderViaProjectGraph private (toolsPath, ?globalProperties: (stri | |||
|
|
|||
| let bm = BuildManager.DefaultBuildManager | |||
| use sw = new StringWriter() | |||
| let loggers = ProjectLoader.createLoggers allKnownNames binaryLogs sw | |||
| let loggers = ProjectLoader.createLoggers "graph-build" binaryLogs sw | |||
There was a problem hiding this comment.
Previously we'd create a binlog for each project that we were design time building. This would cause excessive slowdowns.
| @@ -532,7 +532,7 @@ module ProjectLoader = | |||
| let pi = project.CreateProjectInstance() | |||
| getTfm pi isLegacyFrameworkProj | |||
|
|
|||
| let createLoggers (paths: string seq) (binaryLogs: BinaryLogGeneration) (sw: StringWriter) = | |||
| let createLoggers (path: string) (binaryLogs: BinaryLogGeneration) (sw: StringWriter) = | |||
There was a problem hiding this comment.
Since both call sites were only passing in a single path I changed this. Though it is public so would be a breaking change if someone was using it.
TheAngryByrd
force-pushed
the
fix-slow-graph-binlog
branch
from
6ee4aca to
49c5aa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.