Make InspectSln.parseFolder return the list of files in a folder #233
Conversation
| |> Seq.map (fun p -> parseItem p) | ||
| |> List.ofSeq, | ||
|
|
||
| folder.Files |
There was a problem hiding this comment.
folder.Files can be null here, hence the Option.ofObj stuff to turn such a case into an empty collection
test/Ionide.ProjInfo.Tests/Tests.fs
Outdated
| let solutionItem = solutionContents.Items[0] | ||
|
|
||
| Expect.equal solutionItem.Guid (Guid("8ec462fd-d22e-90a8-e5ce-7e832ba40c5d")) "Should have the epxcted guid" | ||
| Expect.equal solutionItem.Name "\\Solution Items\\" "Should have the expected folder name" |
There was a problem hiding this comment.
I was going to ask about the slashes here as a separate bug - Ionide is displaying them in the solution explorer and I don't think it should e.g.
but then the new slnx format does seem to include them in the actual solution file:
So - not sure if they should be filtered here, or returned to the caller and changed for display purposes higher up?
There was a problem hiding this comment.
and that's made me realise that Visual Studio displays nested folders as a tree
Whereas Ionide displays them alongside each other
I suppose that's a separate bug though
There was a problem hiding this comment.
IIRC we had some tree support in the past - I wonder if the odd slash usage/naming is throwing that off. Agree that's a separate issue though.
Since VS is stripping the slashes for UI purposes, we could/should as well. The values here almost look like xpath path expressions, except the slashes are the wrong direction...
There was a problem hiding this comment.
IIRC we had some tree support in the past
I tried downgrading Ionide to 7.22.0 and the nesting works in that version, so I'll have a look at that next week.
There was a problem hiding this comment.
Looks like version 0.68.0 returned the folders as a tree, and now it's returning a flat list as it appears in the solution file
|
Looks like this PR and the other one together have caused a test failure, I'll have a look at fixing the expected results |
3 participants
refs #231
As discussed in #231 I believe that it did this before the change to use the new MS solution parser, and changing it to return guids instead doesn't seem right.
Also added a new test with a solution that contains a folder with just files (no project items)