Skip to content

Conversation

@Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Oct 18, 2025

This picks up fixes for the issues with the old version breaking the build when running inside Visual Studio

This picks up fixes for the issues with the old version breaking the build when running inside Visual Studio
### Changed

* We now use the [Microsoft.VisualStudio.SolutionPersistence](https://github.com/microsoft/vs-solutionpersistence) library to parse solution files. This should be more reliable and faster than the previous implementation.
- We now use the [Microsoft.VisualStudio.SolutionPersistence](https://github.com/microsoft/vs-solutionpersistence) library to parse solution files. This should be more reliable and faster than the previous implementation.
Copy link
Contributor Author

@Numpsy Numpsy Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes from * to - ref the discussion in ionide/KeepAChangelog#37 about accepting both characters.
However, as it stands this file is using a mixed set of both (some changelog entries use - and some use *), so I'd suggest that it should be internally consistent and use one or the other if nothing else.

@TheAngryByrd TheAngryByrd merged commit 39d1b85 into ionide:main Oct 18, 2025
3 checks passed
@TheAngryByrd
Copy link
Member

Thanks!

@Numpsy Numpsy deleted the keepachangelog branch October 19, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants