-
Notifications
You must be signed in to change notification settings - Fork 1
chore(deps): update all golang and github action dependencies & upgrades to golang 1.23 #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
4140fb0
to
47464ee
Compare
e65094b
to
a466e7f
Compare
a466e7f
to
37ec01c
Compare
github.com/gofiber/adaptor/v2 v2.2.1 | ||
github.com/gofiber/fiber/v2 v2.52.5 | ||
github.com/gofiber/fiber/v2 v2.52.6 | ||
github.com/golang/mock v1.7.0-rc.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move this to go.uber.org/mock
github.com/golang/mock v1.7.0-rc.1 | ||
github.com/golangci/golangci-lint v1.54.2 | ||
github.com/golangci/golangci-lint v1.57.2 | ||
github.com/helm/chart-releaser v1.4.1 | ||
github.com/katallaxie/pkg v0.5.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how? lets do this in a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy the helpers to the 'pkg' of this repo.
GORELEASER_VERSION ?= v2.7.0 | ||
|
||
|
||
.PHONY: helm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't better to use the local helm cli?
HELM ?= helm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just copied it from our other operators
"sigs.k8s.io/controller-runtime/pkg/manager" | ||
"sigs.k8s.io/controller-runtime/pkg/webhook" | ||
|
||
metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reorder imports
github.com/chenjiandongx/pinger v0.2.0 | ||
github.com/go-logr/logr v1.2.4 | ||
github.com/chenjiandongx/pinger v0.3.0 | ||
github.com/go-logr/logr v1.4.2 | ||
github.com/gofiber/adaptor/v2 v2.2.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this in favor of https://github.com/gofiber/fiber/tree/v2/middleware/adaptor
github.com/golang/mock v1.7.0-rc.1 | ||
github.com/golangci/golangci-lint v1.54.2 | ||
github.com/golangci/golangci-lint v1.57.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version: v1.64.6
github.com/golang/mock v1.7.0-rc.1 | ||
github.com/golangci/golangci-lint v1.54.2 | ||
github.com/golangci/golangci-lint v1.57.2 | ||
github.com/helm/chart-releaser v1.4.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you bump this as well.
What has been done?
How has this been tested?