fix: 243 tx to InTx for account,tab,user #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default Project
|
||||||||||||||||||||||||||||
| Project |
Default Project
|
| Branch Review |
staging
|
| Run status |
|
| Run duration | 00m 31s |
| Commit |
|
| Committer | Diyor Khaydarov |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
3
|
| View all changes introduced in this branch ↗︎ | |
diyor28
reviewed
Apr 16, 2025
| @@ -55,7 +55,7 @@ func (c *AccountController) Register(r *mux.Router) { | |||
|
|
|||
| setRouter := r.PathPrefix(c.basePath).Subrouter() | |||
| setRouter.Use(commonMiddleware...) | |||
| setRouter.Use(middleware.WithTransaction()) | |||
| //setRouter.Use(middleware.WithTransaction()) | |||
There was a problem hiding this comment.
You can completely remove this line
diyor28
reviewed
Apr 16, 2025
diyor28
reviewed
Apr 16, 2025
|
|
||
| var createdUser user.User | ||
| err = composables.InTx(ctx, func(txCtx context.Context) error { | ||
| data, err = data.SetPassword(data.Password()) |
There was a problem hiding this comment.
This doesn't necessarily need to be part the transaction
diyor28
reviewed
Apr 16, 2025
modules/core/handlers/tab_handler.go
Outdated
| } | ||
| if err := h.tabService.CreateMany(ctxWithUser, tabs); err != nil { | ||
| h.logger.Errorf("Failed to create tab for user %d: %v", user.ID(), err) | ||
| err := composables.InTx(ctx, func(txCtx context.Context) error { |
There was a problem hiding this comment.
This call is not necessary since you're opening transactions inside service calls. If you want both calls to be part of a single transaction, create a service method that wraps these two operations in a single transaction
There was a problem hiding this comment.
made by calling the service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.