feat: use a development container that supports hot reloading #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abdelmounim-dev
commented
Jan 17, 2025
abdelmounim-dev
commented
- The development container supports hot reloading.
- docs/CONTRIBUTING.MD includes comprehensive setup and usage documentation.
- Developers can run and test the application inside the container without additional setup.
- File changes trigger automatic reloads in the running container.
diyor28
requested changes
Jan 17, 2025
docs/CONTRIBUTING.MD
Outdated
There was a problem hiding this comment.
No need to override the local setup docs, better to just add a separate setup with docker section
Makefile
Outdated
|
|
||
| # Compile TailwindCSS (without watch) | ||
| css: | ||
| tailwindcss -c tailwind.config.js -i $(TAILWIND_INPUT) -o $(TAILWIND_OUTPUT) --minify | ||
| npx tailwindcss -c tailwind.config.js -i $(TAILWIND_INPUT) -o $(TAILWIND_OUTPUT) --minify |
Dockerfile.dev
Outdated
| RUN curl -sSfL https://raw.githubusercontent.com/cosmtrek/air/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.61.5 | ||
|
|
||
| # Install TailwindCSS | ||
| RUN npm install -g [email protected] |
There was a problem hiding this comment.
Use installation instructions from the prod file. To install the standalone api without the need for nodejs
Dockerfile.dev
Outdated
There was a problem hiding this comment.
Also I think you can turn this file into a separate target in the main file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.