Skip to content
This repository was archived by the owner on Feb 26, 2021. It is now read-only.

Basic auth#131

Open
bmavity wants to merge 5 commits into
iotaledger-archive:devfrom
bmavity:basic_auth
Open

Basic auth#131
bmavity wants to merge 5 commits into
iotaledger-archive:devfrom
bmavity:basic_auth

Conversation

@bmavity
Copy link
Copy Markdown

@bmavity bmavity commented Jun 21, 2017

This pull request is open for feedback, but is not fully ready as it requires a couple more additions. It adds Username and Password entry to the light wallet configuration and saves the configuration.

It does not yet

  • Display a different error message when the server requires authentication
  • Properly update username and password values

It also requires iotaledger-archive/iota.js#35 to be merged.

@bmavity bmavity changed the base branch from master to dev June 21, 2017 22:21
@bmavity
Copy link
Copy Markdown
Author

bmavity commented Jun 22, 2017

Turns out that the iota.lib.js library does not return the status code of the request so the current error message will have to do for now.

Let me know if this is ok or if you need me to change anything.

This resolves #133

@bmavity bmavity force-pushed the basic_auth branch 2 times, most recently from 111b777 to d579eb9 Compare July 8, 2017 22:35
@bmavity
Copy link
Copy Markdown
Author

bmavity commented Jul 8, 2017

I rebased this off of the current dev branch. Still needs iotaledger-archive/iota.js#35 . I was too slow yesterday. ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant