Skip to content

Conversation

@Alex6323
Copy link
Contributor

@Alex6323 Alex6323 commented Nov 20, 2025

Forwards some utility traits to the bindings by deriving them from the inner core type and exporting them. uniffi supports trait exports as mentioned here https://mozilla.github.io/uniffi-rs/latest/types/uniffi_traits.html

Closes #322 , but there's no point in not exporting other traits as well if we can to match as closely as possible the convenient Rust API for bindings users, so I'll do that as well.

Not sure why yet, but Ord (supported according to the docs) doesn't work.

Also fixes #433, which is necessary to make the CI pass.

@coveralls
Copy link

coveralls commented Nov 20, 2025

Pull Request Test Coverage Report for Build 19564185408

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.004%) to 85.262%

Files with Coverage Reduction New Missed Lines %
crates/iota-sdk-types/src/crypto/signature.rs 1 74.13%
crates/iota-sdk-types/src/crypto/passkey.rs 2 81.88%
Totals Coverage Status
Change from base Build 19557035200: 0.004%
Covered Lines: 20965
Relevant Lines: 24589

💛 - Coveralls

@Alex6323 Alex6323 marked this pull request as ready for review November 20, 2025 13:57
@Alex6323 Alex6323 requested a review from a team as a code owner November 20, 2025 13:57
@thibault-martinez
Copy link
Member

Having a look, don't merge just yet pls

Co-authored-by: Thibault Martinez <[email protected]>
@Thoralf-M Thoralf-M merged commit 741b08f into develop Jan 12, 2026
17 checks passed
@Thoralf-M Thoralf-M deleted the feat/uniffi-export-derived-traits branch January 12, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kotlin/Java JNA limitation requires smaller bindings interface Allow direct object comparison in bindings if types impl Eq

6 participants