feat(binding): expose more intent types #518
Open
+3,139
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaughterOfMars
approved these changes
Jan 13, 2026
Member
|
CI not happy :( |
Thoralf-M
approved these changes
Jan 15, 2026
| /// Returns the intent prefix length, i.e. the number of bytes prepended to the | ||
| /// data before being signed. | ||
| #[uniffi::export] | ||
| pub fn intent_prefix_length() -> u64 { |
Contributor
Author
There was a problem hiding this comment.
Because it's also public for the Rust part of the SDK.
Comment on lines
202
to
210
| pub fn intent_from_bytes(bytes: &[u8]) -> Result<Intent, IntentError> { | ||
| Ok(Intent(iota_sdk::types::crypto::Intent::from_bytes(bytes)?)) | ||
| } | ||
|
|
||
| /// Create a signing intent from a hex string. | ||
| #[uniffi::export] | ||
| pub fn intent_from_hex_string(hex: &str) -> Result<Intent, IntentError> { | ||
| Ok(Intent(iota_sdk::types::crypto::Intent::from_str(hex)?)) | ||
| } |
Member
There was a problem hiding this comment.
Why are these not constructors?
Contributor
Author
There was a problem hiding this comment.
you're right, that's weird
| /// A 1-byte domain separator for hashing Object ID in IOTA. It starts from | ||
| /// 0xf0 to ensure no hashing collision for any ObjectID vs IotaAddress which is | ||
| /// derived as the hash of `flag || pubkey`. See | ||
| /// `iota_types::crypto::SignatureScheme::flag()`. |
Member
There was a problem hiding this comment.
no rust ref in FFI docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #439