Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iota-protocol, iota-execution, iota-framework): Update signing verifier constants setting #5588

Open
wants to merge 6 commits into
base: vm-lang/upstream-nov-dic-24
Choose a base branch
from

Conversation

Dkwcs
Copy link
Contributor

@Dkwcs Dkwcs commented Feb 24, 2025

Description of change

Allowing verifier constants for limits and metering to be set by the node config instead of being hardcoded into the binary
According to changes.

Links to any relevant issues

Fixes #5246 .

Type of change

  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

Run tests:
TODO

…r constants for limits and metering to be set by the node config instead of being hardcoded into

the binary
@Dkwcs Dkwcs added the vm-language Issues related to the VM & Language Team label Feb 24, 2025
@Dkwcs Dkwcs self-assigned this Feb 24, 2025
@Dkwcs Dkwcs requested review from a team as code owners February 24, 2025 10:42
Copy link

vercel bot commented Feb 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 4:09pm
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 4:09pm
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 4:09pm
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 4:09pm

@iota-ci iota-ci added the sc-platform Issues related to the Smart Contract Platform group. label Feb 24, 2025
@@ -29,6 +29,7 @@ serde_json.workspace = true
tempfile.workspace = true

# internal dependencies
iota-config.workspace = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this dependency required? Looks like it can be deleted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sc-platform Issues related to the Smart Contract Platform group. vm-language Issues related to the VM & Language Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[execution] Update how verifier constants for signing are set · MystenLabs/sui@89f3a3a
5 participants