-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iota-protocol, iota-execution, iota-framework): Update signing verifier constants setting #5588
Open
Dkwcs
wants to merge
6
commits into
vm-lang/upstream-nov-dic-24
Choose a base branch
from
vm-lang/Update-signing-verifier-constants-setting
base: vm-lang/upstream-nov-dic-24
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(iota-protocol, iota-execution, iota-framework): Update signing verifier constants setting #5588
Dkwcs
wants to merge
6
commits into
vm-lang/upstream-nov-dic-24
from
vm-lang/Update-signing-verifier-constants-setting
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r constants for limits and metering to be set by the node config instead of being hardcoded into the binary
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
Thoralf-M
reviewed
Feb 24, 2025
Thoralf-M
approved these changes
Feb 24, 2025
jkrvivian
approved these changes
Feb 25, 2025
valeriyr
approved these changes
Feb 25, 2025
crates/iota-framework/Cargo.toml
Outdated
@@ -29,6 +29,7 @@ serde_json.workspace = true | |||
tempfile.workspace = true | |||
|
|||
# internal dependencies | |||
iota-config.workspace = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this dependency required? Looks like it can be deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sc-platform
Issues related to the Smart Contract Platform group.
vm-language
Issues related to the VM & Language Team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Allowing verifier constants for limits and metering to be set by the node config instead of being hardcoded into the binary
According to changes.
Links to any relevant issues
Fixes #5246 .
Type of change
How the change has been tested
Run tests:
TODO