Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework): add fun bitwise_not and macro fun max_value #5589

Merged
merged 11 commits into from
Feb 26, 2025
Merged

feat(framework): add fun bitwise_not and macro fun max_value #5589

merged 11 commits into from
Feb 26, 2025

Conversation

nonast
Copy link
Contributor

@nonast nonast commented Feb 24, 2025 •
edited
Loading

Description of change

Added a bitwise not function, fun bitwise_not and maximum value macro, macro fun max_value to u* modules.

Links to any relevant issues

fixes #5131

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Added unit tests

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@nonast nonast self-assigned this Feb 24, 2025
@nonast nonast requested a review from a team as a code owner February 24, 2025 11:24
@vercel Vercel
Copy link

vercel bot commented Feb 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 10:36am
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 10:36am
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 10:36am
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 10:36am

@iota-ci iota-ci added sc-platform Issues related to the Smart Contract Platform group. vm-language Issues related to the VM & Language Team labels Feb 24, 2025
@nonast nonast linked an issue Feb 24, 2025 that may be closed by this pull request
[framework] Add fun bitwise_not and macro fun max_value · MystenLabs/sui@369d44b #5131
Open
valeriyr
valeriyr approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@valeriyr valeriyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nonast nonast requested a review from a team as a code owner February 24, 2025 13:17
@nonast nonast merged commit d0e8afa into vm-lang/upstream-nov-dic-24 Feb 26, 2025
41 checks passed
@nonast nonast deleted the vm-lang/issue-5131-add-bitwise-not-and-max-value branch February 26, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valeriyr valeriyr valeriyr approved these changes

@bingyanglin bingyanglin bingyanglin approved these changes

Assignees

@nonast nonast

Labels
sc-platform Issues related to the Smart Contract Platform group. vm-language Issues related to the VM & Language Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[framework] Add fun bitwise_not and macro fun max_value · MystenLabs/sui@369d44b
4 participants
@nonast @valeriyr @bingyanglin @iota-ci