Skip to content

refactor(indexer): Rework config and cli arguments #6517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tomxey
Copy link
Contributor

@tomxey tomxey commented Apr 22, 2025

Description of change

This patch reworks a number of the indexer configs and cli arguments to try and centralize where the configuration for the indexer is loaded. This also cleans up the cli arguments into well defined subcommands instead of using boolean flags for deciding if a jsonrpc or indexer writer service should be started.

The old CLI is still kept for backward compatibility with an intention to remove it in the future.

Links to any relevant issues

fixes: #6201

Type of change

Rafactoring

How the change has been tested

The tests are still failing, patch is WIP
cargo ci-clippy
cargo test --profile simulator --package iota-indexer --test rpc-tests --all-features

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

Release Notes

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@tomxey tomxey self-assigned this Apr 22, 2025
Copy link

vercel bot commented Apr 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Apr 22, 2025 11:27am
apps-ui-kit ⬜️ Ignored (Inspect) Apr 22, 2025 11:27am
rebased-explorer ⬜️ Ignored (Inspect) Apr 22, 2025 11:27am
wallet-dashboard ⬜️ Ignored (Inspect) Apr 22, 2025 11:27am

@iota-ci iota-ci added infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group. labels Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

indexer: rework config and cli arguments (#19162)
2 participants