feat: use json rpc apis for IOTA-Names reads #6617
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
iota-ci
added
dev-tools
DaughterOfMars
force-pushed
the
dev-tools/use-json-rpc-apis
branch
from
c4fdae2 to
a3b9cb9
Compare
thibault-martinez
force-pushed
the
iota-names
branch
from
0108fd2 to
55a4d2f
Compare
DaughterOfMars
force-pushed
the
dev-tools/use-json-rpc-apis
branch
from
a3b9cb9 to
5c3bd1b
Compare
How do you think I implemented |
I was thinking of using it in |
crates/iota/src/name_commands.rs
Outdated
| } else { | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
Reminder to use GetAllPages if merged before
| let mut nfts = get_owned_nfts::<IotaNamesRegistration>(address, context).await?; | ||
| let subdomain_nfts = | ||
| get_owned_nfts::<SubdomainRegistration>(address, context).await?; | ||
| nfts.extend(subdomain_nfts.into_iter().map(|nft| nft.into_inner())); |
There was a problem hiding this comment.
How come this wasn't creating duplicates btw?
There was a problem hiding this comment.
Not sure what you mean
There was a problem hiding this comment.
Why were we requesting both IotaNamesRegistration and SubdomainRegistration?
There was a problem hiding this comment.
Because they don't return the other one
thibault-martinez
approved these changes
May 7, 2025
thibault-martinez
requested changes
May 7, 2025
Alex6323
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Updates the CLI commands lookup, reverse-lookup, get-user-data, and list to use the new JSON RPC APIs.
Links to any relevant issues
#6394
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
The
config.rsfile was modified to load ENV vars for the package IDs and such, then a localnet was started, and the packages published. The ENV was set and the server was restarted. Then the client was run against the existing server.Release Notes