Remove shimmer mention from tutorial #6776
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
github-actions
bot
added
documentation
salaheldinsoliman
force-pushed
the
devx/remove-shimmer-mention
branch
from
300ff8b to
c28e03b
Compare
|
✅ Vercel Preview Deployment is ready! |
vivekjain23
requested changes
May 7, 2025
|
|
||
| The `deploy_marketplace_shimmer.js` script will deploy the NFTMarketplace contract to the ShimmerEVM Testnet and save the contract address to a file called `NFTMarketplace.txt`. | ||
| The `deploy_marketplace_iota.js` script will deploy the NFTMarketplace contract to the IotaEVM Testnet and save the contract address to a file called `NFTMarketplace.txt`. |
There was a problem hiding this comment.
Suggested change
| The `deploy_marketplace_iota.js` script will deploy the NFTMarketplace contract to the IotaEVM Testnet and save the contract address to a file called `NFTMarketplace.txt`. | |
| The `deploy_marketplace_iota.js` script will deploy the NFTMarketplace contract to the IOTA EVM Testnet and save the contract address to a file called `NFTMarketplace.txt`. |
| ``` | ||
|
|
||
| This will deploy the NFTMarketplace contract to the ShimmerEVM Testnet and save the contract address to a file. | ||
| This will deploy the NFTMarketplace contract to the IotaEVM Testnet and save the contract address to a file. |
There was a problem hiding this comment.
Suggested change
| This will deploy the NFTMarketplace contract to the IotaEVM Testnet and save the contract address to a file. | |
| This will deploy the NFTMarketplace contract to the IOTA EVM Testnet and save the contract address to a file. |
|
|
||
| This script will deploy the `MyERC721` contract to the ShimmerEVM Testnet and save the contract's address to a file called `MyERC721.txt`. | ||
| This script will deploy the `MyERC721` contract to the IotaEVM Testnet and save the contract's address to a file called `MyERC721.txt`. |
There was a problem hiding this comment.
Suggested change
| This script will deploy the `MyERC721` contract to the IotaEVM Testnet and save the contract's address to a file called `MyERC721.txt`. | |
| This script will deploy the `MyERC721` contract to the IOTA EVM Testnet and save the contract's address to a file called `MyERC721.txt`. |
| ``` | ||
|
|
||
| ## Conclusion | ||
|
|
||
| In this first part of the cross-chain NFT marketplace tutorial, we have set up the project and deployed the NFTMarketplace contract to the ShimmerEVM Testnet. We have also deployed the MyERC721 contract, minted an NFT and then listed it on the marketplace. In the next part, we will manually bridge NFTs from BNB Testnet and Shimmer Testnet to the ShimmerEVM Testnet and list them on the same marketplace. | ||
| In this first part of the cross-chain NFT marketplace tutorial, we have set up the project and deployed the NFTMarketplace contract to the IotaEVM Testnet. We have also deployed the MyERC721 contract, minted an NFT and then listed it on the marketplace. In the next part, we will manually bridge NFTs from BNB Testnet and Iota Testnet to the IotaEVM Testnet and list them on the same marketplace. |
There was a problem hiding this comment.
Suggested change
| In this first part of the cross-chain NFT marketplace tutorial, we have set up the project and deployed the NFTMarketplace contract to the IotaEVM Testnet. We have also deployed the MyERC721 contract, minted an NFT and then listed it on the marketplace. In the next part, we will manually bridge NFTs from BNB Testnet and Iota Testnet to the IotaEVM Testnet and list them on the same marketplace. | |
| In this first part of the cross-chain NFT marketplace tutorial, we have set up the project and deployed the NFTMarketplace contract to the IOTA EVM Testnet. We have also deployed the MyERC721 contract, minted an NFT and then listed it on the marketplace. In the next part, we will manually bridge NFTs from BNB Testnet and IOTA Testnet to the IOTA EVM Testnet and list them on the same marketplace. |
| 6. Configure the `MyONFT721` contract to receive NFTs from the `MyProxyONFT721` contract. [set_trusted_remote_shimmer.js](#set_trusted_remote_shimmerjs) | ||
| 7. Send an NFT from the BNB Testnet to the ShimmerEVM Testnet. [send_nft_bnb_to_shimmer.js](#send_nftjs) | ||
| 6. Configure the `MyONFT721` contract to receive NFTs from the `MyProxyONFT721` contract. [set_trusted_remote_iota.js](#set_trusted_remote_iotajs) | ||
| 7. Send an NFT from the BNB Testnet to the IotaEVM Testnet. [send_nft_bnb_to_iota.js](#send_nftjs) |
There was a problem hiding this comment.
Suggested change
| 7. Send an NFT from the BNB Testnet to the IotaEVM Testnet. [send_nft_bnb_to_iota.js](#send_nftjs) | |
| 7. Send an NFT from the BNB Testnet to the IOTA EVM Testnet. [send_nft_bnb_to_iota.js](#send_nftjs) |
|
|
||
| Deploy the `MyONFT721` contract to the Shimmer EVM Testnet and save its address in a file called `MyONFT721_Shimmer.txt` using the following script: | ||
| Deploy the `MyONFT721` contract to the Iota EVM Testnet and save its address in a file called `MyONFT721_Iota.txt` using the following script: |
There was a problem hiding this comment.
Suggested change
| Deploy the `MyONFT721` contract to the Iota EVM Testnet and save its address in a file called `MyONFT721_Iota.txt` using the following script: | |
| Deploy the `MyONFT721` contract to the IOTA EVM Testnet and save its address in a file called `MyONFT721_Iota.txt` using the following script: |
|
|
||
| On the ShimmerEVM Testnet, call the `MyONFT721` contract to set the `MyProxyONFT721` contract as a trusted remote contract. This will allow the `MyONFT721` contract to receive NFTs from the `MyProxyONFT721` contract. | ||
| On the IotaEVM Testnet, call the `MyONFT721` contract to set the `MyProxyONFT721` contract as a trusted remote contract. This will allow the `MyONFT721` contract to receive NFTs from the `MyProxyONFT721` contract. |
There was a problem hiding this comment.
Suggested change
| On the IotaEVM Testnet, call the `MyONFT721` contract to set the `MyProxyONFT721` contract as a trusted remote contract. This will allow the `MyONFT721` contract to receive NFTs from the `MyProxyONFT721` contract. | |
| On the IOTA EVM Testnet, call the `MyONFT721` contract to set the `MyProxyONFT721` contract as a trusted remote contract. This will allow the `MyONFT721` contract to receive NFTs from the `MyProxyONFT721` contract. |
| ``` | ||
|
|
||
| ### send_nft.js | ||
|
|
||
| Finally, call the `MyProxyONFT721` contract on the BNB Testnet to send an NFT to the `MyONFT721` contract on the ShimmerEVM Testnet. This script approves the `MyProxyONFT721` contract to transfer the NFT and then sends the NFT to the `MyONFT721` contract. | ||
| Finally, call the `MyProxyONFT721` contract on the BNB Testnet to send an NFT to the `MyONFT721` contract on the IotaEVM Testnet. This script approves the `MyProxyONFT721` contract to transfer the NFT and then sends the NFT to the `MyONFT721` contract. |
There was a problem hiding this comment.
Suggested change
| Finally, call the `MyProxyONFT721` contract on the BNB Testnet to send an NFT to the `MyONFT721` contract on the IotaEVM Testnet. This script approves the `MyProxyONFT721` contract to transfer the NFT and then sends the NFT to the `MyONFT721` contract. | |
| Finally, call the `MyProxyONFT721` contract on the BNB Testnet to send an NFT to the `MyONFT721` contract on the IOTA EVM Testnet. This script approves the `MyProxyONFT721` contract to transfer the NFT and then sends the NFT to the `MyONFT721` contract. |
| @@ -279,7 +279,7 @@ npx hardhat run scripts/send_nft.js --network bnbTestnet | |||
|
|
|||
| :::note | |||
|
|
|||
| The script will take some time to complete, as it waits for the NFT to be received on the ShimmerEVM Testnet. | |||
| The script will take some time to complete, as it waits for the NFT to be received on the IotaEVM Testnet. | |||
There was a problem hiding this comment.
Suggested change
| The script will take some time to complete, as it waits for the NFT to be received on the IotaEVM Testnet. | |
| The script will take some time to complete, as it waits for the NFT to be received on the IOTA EVM Testnet. |
| ``` | ||
|
|
||
| ## Conclusion | ||
|
|
||
| In the second part of this tutorial, you manually bridged an NFT from the BNB Testnet to the ShimmerEVM Testnet and listed it on the NFT marketplace. The final part of the series will explore how to create a cross-chain swap contract that allows users to trade NFTs across chains. | ||
| In the second part of this tutorial, you manually bridged an NFT from the BNB Testnet to the IotaEVM Testnet and listed it on the NFT marketplace. The final part of the series will explore how to create a cross-chain swap contract that allows users to trade NFTs across chains. |
There was a problem hiding this comment.
Suggested change
| In the second part of this tutorial, you manually bridged an NFT from the BNB Testnet to the IotaEVM Testnet and listed it on the NFT marketplace. The final part of the series will explore how to create a cross-chain swap contract that allows users to trade NFTs across chains. | |
| In the second part of this tutorial, you manually bridged an NFT from the BNB Testnet to the IOTA EVM Testnet and listed it on the NFT marketplace. The final part of the series will explore how to create a cross-chain swap contract that allows users to trade NFTs across chains. |
richardmands
reviewed
May 7, 2025
There was a problem hiding this comment.
Should this image have the ShimmerEVM reference updated as well?
richardmands
reviewed
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Removed Shimmer mention from EVM tutorial
Links to any relevant issues
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Infrastructure QA (only required for crates that are maintained by @iotaledger/infrastructure)
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.