-
Notifications
You must be signed in to change notification settings - Fork 34
feat: Add decode-key command to http_kv_tool #6795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: core-node/upstream-changes/mainnet-1.32.2-1.33.3
Are you sure you want to change the base?
feat: Add decode-key command to http_kv_tool #6795
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
path_elements_to_key(path_elts.0, path_elts.1.as_str()).unwrap(), | ||
key | ||
); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder that the Key::Events
was removed at #5259, so we don't have the corresponding testing from the upstream here.
path_elements_to_key(path_elts.0, path_elts.1.as_str()).unwrap(), | ||
key | ||
); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder that the Key::CheckpointContentsByDigest
was removed at #5215, so we don't have the corresponding testing from the upstream here.
@@ -282,6 +282,42 @@ enum Value { | |||
TxToCheckpoint(CheckpointSequenceNumber), | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder the function key_to_path_elements
was removed at #5296, so we don't port the upstream change for the key_to_path_elements
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to adapt the newto_path_elements
then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
key_to_path_elements was only made public upstream so we already have the equivalent if I'm not mistaken ?
312b9c5
to
d3c32a2
Compare
b6a68ab
to
458d00f
Compare
5d8f873
to
144dfcb
Compare
144dfcb
to
493989f
Compare
493989f
to
a35eeed
Compare
Description of change
Port MystenLabs/sui@ddeffaa
From Sui's commit description:
e.g.
http_kv_tool decode-key -u https://transactions.sui.io/mainnet/cP1pPYHRXroEHhXrsD_uy-kbAcH5lZguUEPfocX0zXsIsR0GAAAAAA/ob
Note that the changes are adapted to our codebase, like using the
ItemType
from our sideLinks to any relevant issues
Part of #3990
Type of change
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.