Skip to content

feat: Add decode-key command to http_kv_tool #6795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: core-node/upstream-changes/mainnet-1.32.2-1.33.3
Choose a base branch
from

Conversation

jkrvivian
Copy link
Contributor

Description of change

Port MystenLabs/sui@ddeffaa

From Sui's commit description:
e.g.
http_kv_tool decode-key -u https://transactions.sui.io/mainnet/cP1pPYHRXroEHhXrsD_uy-kbAcH5lZguUEPfocX0zXsIsR0GAAAAAA/ob

Note that the changes are adapted to our codebase, like using the ItemType from our side

Links to any relevant issues

Part of #3990

Type of change

  • Enhancement

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@jkrvivian jkrvivian self-assigned this May 7, 2025
@jkrvivian jkrvivian requested review from a team as code owners May 7, 2025 13:39
@jkrvivian jkrvivian added the node Issues related to the Core Node team label May 7, 2025
Copy link

vercel bot commented May 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview May 21, 2025 4:19pm
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback May 21, 2025 4:19pm
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview May 21, 2025 4:19pm
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback May 21, 2025 4:19pm

path_elements_to_key(path_elts.0, path_elts.1.as_str()).unwrap(),
key
);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder that the Key::Events was removed at #5259, so we don't have the corresponding testing from the upstream here.

path_elements_to_key(path_elts.0, path_elts.1.as_str()).unwrap(),
key
);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder that the Key::CheckpointContentsByDigest was removed at #5215, so we don't have the corresponding testing from the upstream here.

@@ -282,6 +282,42 @@ enum Value {
TxToCheckpoint(CheckpointSequenceNumber),
}

Copy link
Contributor

@bingyanglin bingyanglin May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder the function key_to_path_elements was removed at #5296, so we don't port the upstream change for the key_to_path_elements here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to adapt the newto_path_elements then?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key_to_path_elements was only made public upstream so we already have the equivalent if I'm not mistaken ?

@bingyanglin bingyanglin force-pushed the core-node/upstream-changes/mainnet-1.32.2-1.33.3 branch from 312b9c5 to d3c32a2 Compare May 20, 2025 02:40
@bingyanglin bingyanglin requested review from a team as code owners May 20, 2025 02:40
@alexsporn alexsporn changed the title upstream(v1.32-v1.33): Add decode-key command to http_kv_tool feat: Add decode-key command to http_kv_tool May 20, 2025
@muXxer muXxer force-pushed the core-node/upstream-changes/mainnet-1.32.2-1.33.3 branch from b6a68ab to 458d00f Compare May 21, 2025 16:05
@muXxer muXxer force-pushed the node/upstream-v1.32-1.33/ddeff branch from 5d8f873 to 144dfcb Compare May 21, 2025 16:06
@nmrshll nmrshll force-pushed the node/upstream-v1.32-1.33/ddeff branch from 144dfcb to 493989f Compare May 21, 2025 16:06
@muXxer muXxer force-pushed the node/upstream-v1.32-1.33/ddeff branch from 493989f to a35eeed Compare May 21, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-protocol node Issues related to the Core Node team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants