Skip to content

fix(wallet): connect to dashboard with closed connect window. #6815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix(wallet): connect to dashboard with closed connect window. #6815

wants to merge 3 commits into from

Conversation

panteleymonchuk
Copy link
Contributor

@panteleymonchuk panteleymonchuk commented May 8, 2025 •
edited
Loading

For the context how this issue was reproducible to me:

  1. Open dashboard (or any dapp)
  2. Click connect which opens connect popup from dappkit
  3. Select the IOTA Wallet (which should not be approved beforehand) which opens the wallet extension in popup mode
  4. Close manually the wallet popup, dont approve
  5. Go to step 2 again until error pops

After 5-6 attempts when I open dashboard and try to connect, I get error. This is happened because of handler for close window wasn't fired, so in extension's storage we have not completed value (responseDate: null)

Alternative way how to reproduce issue:

  1. Go to chrome://extensions/
  2. Find extension.
  3. Press "service worker"
  4. Go to "application" tab > extensions storage > local
  5. Open "permissions" row
  6. change responseDate to null for wallet-dashboard.iota.org

Links to any relevant issues

Closes #6804

@panteleymonchuk panteleymonchuk requested a review from a team as a code owner May 8, 2025 11:29
@vercel Vercel
Copy link

vercel bot commented May 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apps-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2025 9:03am
apps-ui-kit ✅ Ready (Inspect) Visit Preview May 20, 2025 9:03am
rebased-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2025 9:03am
wallet-dashboard ✅ Ready (Inspect) Visit Preview May 20, 2025 9:03am

@panteleymonchuk panteleymonchuk added tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet wallet-dashboard Issues related to the Wallet Dashboard dApp labels May 8, 2025
@github-actions github-actions bot removed tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp labels May 8, 2025
@iota-ci iota-ci added the tooling Issues related to the Tooling team label May 8, 2025
@panteleymonchuk panteleymonchuk added the wallet-dashboard Issues related to the Wallet Dashboard dApp label May 8, 2025
evavirseda
evavirseda reviewed May 18, 2025
View reviewed changes
Copy link
Contributor

@evavirseda evavirseda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any hints or instructions to help reproduce it and better understand what's going on? 🫣 🙏
I just saw it in an issue comment 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evavirseda evavirseda evavirseda left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate why dashboard fails to connect with wallet
4 participants
@panteleymonchuk @evavirseda @iota-ci @marc2332