feat(CLI)!: Split iota names set-target-address
#6878
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
iota-ci
added
dev-tools
DaughterOfMars
changed the title
set-target-address
| Ok(match self { | ||
| IotaNamesNftProxy::Domain(_) => { | ||
| let names_config = get_iota_names_config(client).await?; | ||
| names_config.package_address.into() |
There was a problem hiding this comment.
Yeah that's where the controller module is.
There was a problem hiding this comment.
But you're not using the controller module anymore?
There was a problem hiding this comment.
No, I am now using it for non-subdomains. For the subdomains it uses the subdomains module
| @@ -1356,6 +1415,13 @@ impl IotaNamesNftProxy { | |||
| } | |||
|
|
|||
| fn module_name(&self) -> &'static str { | |||
| match self { | |||
| IotaNamesNftProxy::Domain(_) => "controller", | |||
There was a problem hiding this comment.
Tbh this feels weird, very tailored to solve this PR's issue
There was a problem hiding this comment.
Yeah, I know. But how would you rather do it?
There was a problem hiding this comment.
I think we need to either:
- resolve the module name when it's actually needed; or
- rename this function
module_nameis too broad for this, maybecontroller_module_nameor something assubdomain_proxyessentially forward to the controller anyway
There was a problem hiding this comment.
Also applies to package_id though, I think I need to think a bit more about it, I don't like it
Description of change
Splits the
set-target-addresscommand intounset-target-address. Theset-target-addresswill now default to the active address when calling without the optional param.Links to any relevant issues
Closes https://github.com/iotaledger/iota-names/issues/190
Type of change
Choose a type of change, and delete any options that are not relevant.
Release Notes
set-target-addresscommand intoset-target-addressandunset-target-address.