feat(CLI)!: Split iota names set-target-address
#6878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
iota-ci
added
dev-tools
DaughterOfMars
changed the title
set-target-address
Thoralf-M
reviewed
May 19, 2025
Thoralf-M
reviewed
May 20, 2025
Thoralf-M
approved these changes
May 20, 2025
Alex6323
reviewed
May 20, 2025
…edger/iota into dev-tools/split-set-target
thibault-martinez
approved these changes
Jun 18, 2025
itsyaasir
pushed a commit
that referenced
this pull request
Jun 30, 2025
# Description of change Splits the `set-target-address` command into `unset-target-address`. The `set-target-address` will now default to the active address when calling without the optional param. ## Links to any relevant issues Closes iotaledger/iota-names#190 ## Type of change Choose a type of change, and delete any options that are not relevant. - Breaking change (fix or feature that would cause existing functionality to not work as expected) ### Release Notes <!-- Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. --> - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [x] CLI: Split the `set-target-address` command into `set-target-address` and `unset-target-address`. - [ ] Rust SDK: - [ ] REST API: --------- Co-authored-by: Thibault Martinez <[email protected]>
jkrvivian
pushed a commit
that referenced
this pull request
Jul 4, 2025
# Description of change Splits the `set-target-address` command into `unset-target-address`. The `set-target-address` will now default to the active address when calling without the optional param. ## Links to any relevant issues Closes iotaledger/iota-names#190 ## Type of change Choose a type of change, and delete any options that are not relevant. - Breaking change (fix or feature that would cause existing functionality to not work as expected) ### Release Notes <!-- Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. --> - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [x] CLI: Split the `set-target-address` command into `set-target-address` and `unset-target-address`. - [ ] Rust SDK: - [ ] REST API: --------- Co-authored-by: Thibault Martinez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Splits the
set-target-addresscommand intounset-target-address. Theset-target-addresswill now default to the active address when calling without the optional param.Links to any relevant issues
Closes https://github.com/iotaledger/iota-names/issues/190
Type of change
Choose a type of change, and delete any options that are not relevant.
Release Notes
set-target-addresscommand intoset-target-addressandunset-target-address.