fix(package-resolver): make pure_input_layouts more lenient #6976
+171
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch allows function-resolution failures while resolving types of pure inputs. This enables callers to have information on the values passed to non-existent functions which lead to failed transactions.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
iota-ci
added
infrastructure
miker83z
approved these changes
May 23, 2025
samuel-rufi
approved these changes
May 23, 2025
…failed-transactions-inputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This patch handles gracefully the cases where we try to resolve input layouts for arguments of a Move function that does not exist in any published package.
Currently the resolution yields an error leading to errors while to create the response for transactions that have failed due to functions not found in the Indexer JSON-RPC.
This is observed with the following request:
which leads to the error that is reported in #6861
Links to any relevant issues
Fixes #6861
Type of change
How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Added an integration test in
iota-indexerthat tries to create the transaction response from the serialized transaction that has been observed failing in mainnet.Infrastructure QA (only required for crates that are maintained by @iotaledger/infrastructure)
The problem is limited to the response parsing, and does not affect ingestion or deployment