Skip to content

feat(execution): Upstream changes mainnet [1.43.1,1.45.3) [DRAFT] #7206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

miker83z
Copy link
Contributor

@miker83z miker83z commented Jun 3, 2025

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

Be sure to reference any related issues by adding fixes #(issue).

How the change has been tested

  • Basic tests (linting, compilation, formatting, unit/integration tests)
  • Patch-specific tests (correctness, functionality coverage)
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

Release Notes

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Jun 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2025 10:49am
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Jun 11, 2025 10:49am
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2025 10:49am
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Jun 11, 2025 10:49am

@iota-ci iota-ci added sc-platform Issues related to the Smart Contract Platform group. vm-language Issues related to the VM & Language Team labels Jun 3, 2025
@TheMrAI TheMrAI force-pushed the vm-lang/upstream-changes/mainnet-1.43.1-1.45.3 branch from 35761c2 to 79f1ee0 Compare June 5, 2025 12:15
TheMrAI and others added 10 commits June 10, 2025 16:55
…_coin (#7084)

New_coin API should take the type_tag of the coin directly, instead of
allowing arbitrary move types.
According to
[changes](MystenLabs/sui@8a28a6e).
…" was incorrectly used instead (#7126)

# Description of change

Fixed a typo in functions.md where "pbulic" was incorrectly used instead
of "public" in the entry functions section.
According to
[changes](MystenLabs/sui@da0201a7).

## Links to any relevant issues

Fixes #7069 .

## Type of change

- Documentation Fix
…d duplicate "the the" (#7132)

# Description of change

 Removed duplicate "the the”.
According to
[changes](MystenLabs/sui@3b36106).

## Links to any relevant issues

Fixes #7070 .

## Type of change

- Documentation Fix
…l variables." has been removed (#7127)

# Description of change

external-crates/move/documentation/book/src/primitive-types/tuples.md
- They cannot be bound to local variables.  - duplicate has been removed
According to
[changes](MystenLabs/sui@902efbb).

## Links to any relevant issues

Fixes #7072 .

## Type of change

- Documentation Fix
…o canonicalize a type (#7218)

# Description of change

Add a function to the package resolver to canonicalize a type (ensure
all the package IDs it mentions are defining IDs)
According to
[changes](MystenLabs/sui@778e78a#diff-000c960638af936148493636d55c8ea62676d2f051774239fc73e7fc1468bf32).

## Links to any relevant issues

Fixes #7078 .

## How the change has been tested

Run

```
cargo nextest run -p iota-package-resolver
```
…7213)

# Description of change

Consistently use the canonical display format with prefix in error
messages from the package resolver.
According to
[changes](MystenLabs/sui@83f6f17#diff-b327546aaf3e64d31d006c18c86f8f9c478930d7cd6d69389ae0069f35b758f3).

Any snapshot changes haven’t been detected..

## Links to any relevant issues

Fixes #7062 .

## How the change has been tested

Run tests:
```
cargo nextest run         \
  -p iota-graphql-e2e-tests     \
  -p iota-package-resolver
```
…s` (#7216)

Generalize `Resolver::function_parameters` so that it returns the fully
resolved function signature. Previously this function was used to infer
transaction input layouts, but we also need roughly the same logic for
returning a normalized move function.

According to
[changes](MystenLabs/sui@5024b1f#diff-76de243b84e1bcb523b9725574d3ae44530b9a49db102035ad19f2d8d6bb54c3).

Fixes #7060 .

Run

```
cargo nextest run -p iota-package-resolver
```
…nsactional test adapter (#7180)

[run-ci]

According to
[changes](MystenLabs/sui@ae367c4#diff-7a132b89ef988a881b2c5d33b4cee85acb20e6be9c7fc645d26806d7ae307290).
I as see we don’t have iota-indexer-alt-e2e tests and
iota-mvr-graphql-e2e, so changes only touch iota-graphql-e2e- tests.

Only these changes differ from Sui’s commit.
I assume it’s because of the version differences in fastcrypto or
async_graphql.
To comply with how iota-graphql-rpc decodes the JSON cursor … this
traces back to async_graphql = 7.0.7, which uses no padding for
encoding/decoding.

`Ok(Base64::encode(cursor));
`

This likely defaults to:

 - STANDARD base64

 - with padding (=)

 - and possibly using the general character set (+ / /).

But the decoder expects:

- URL_SAFE_NO_PAD

- no padding, using - and _

- matching what async_graphql and the RPC layer parse.

```
return Ok(base64::Engine::encode(
        &base64::engine::general_purpose::URL_SAFE_NO_PAD,
        cursor,
));
```

Fixes #7059  .

- Enhancement (a non-breaking change which adds functionality)

For iota-graphql-e2e- tests run:

`cargo nextest run --features pg_integration`

---------

Co-authored-by: Istvan Davorin Acs <[email protected]>
@TheMrAI TheMrAI force-pushed the vm-lang/upstream-changes/mainnet-1.43.1-1.45.3 branch from 79f1ee0 to be6f54c Compare June 10, 2025 15:06
# Description of change

In
[commit](058b493#diff-17cdfbdc54b5e6dd0eff37a911fbf44167d77ac8342b54ff6f41b8cccfca2671)
some test names weren't following the changes from the original [changes
list](MystenLabs/sui@778e78a#diff-000c960638af936148493636d55c8ea62676d2f051774239fc73e7fc1468bf32).
To avoid any future confusion, these were fixed.

## Links to any relevant issues

Adjusts #7078 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sc-platform Issues related to the Smart Contract Platform group. vm-language Issues related to the VM & Language Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants