-
Notifications
You must be signed in to change notification settings - Fork 36
feat(execution): Upstream changes mainnet [1.43.1,1.45.3) [DRAFT] #7206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
miker83z
wants to merge
11
commits into
develop
Choose a base branch
from
vm-lang/upstream-changes/mainnet-1.43.1-1.45.3
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
35761c2
to
79f1ee0
Compare
Remove dep from sui-e2e-tests -> sui (#21422) · MystenLabs/sui@988531b
…_coin (#7084) New_coin API should take the type_tag of the coin directly, instead of allowing arbitrary move types. According to [changes](MystenLabs/sui@8a28a6e).
…" was incorrectly used instead (#7126) # Description of change Fixed a typo in functions.md where "pbulic" was incorrectly used instead of "public" in the entry functions section. According to [changes](MystenLabs/sui@da0201a7). ## Links to any relevant issues Fixes #7069 . ## Type of change - Documentation Fix
…d duplicate "the the" (#7132) # Description of change Removed duplicate "the the”. According to [changes](MystenLabs/sui@3b36106). ## Links to any relevant issues Fixes #7070 . ## Type of change - Documentation Fix
…l variables." has been removed (#7127) # Description of change external-crates/move/documentation/book/src/primitive-types/tuples.md - They cannot be bound to local variables. - duplicate has been removed According to [changes](MystenLabs/sui@902efbb). ## Links to any relevant issues Fixes #7072 . ## Type of change - Documentation Fix
…o canonicalize a type (#7218) # Description of change Add a function to the package resolver to canonicalize a type (ensure all the package IDs it mentions are defining IDs) According to [changes](MystenLabs/sui@778e78a#diff-000c960638af936148493636d55c8ea62676d2f051774239fc73e7fc1468bf32). ## Links to any relevant issues Fixes #7078 . ## How the change has been tested Run ``` cargo nextest run -p iota-package-resolver ```
…7213) # Description of change Consistently use the canonical display format with prefix in error messages from the package resolver. According to [changes](MystenLabs/sui@83f6f17#diff-b327546aaf3e64d31d006c18c86f8f9c478930d7cd6d69389ae0069f35b758f3). Any snapshot changes haven’t been detected.. ## Links to any relevant issues Fixes #7062 . ## How the change has been tested Run tests: ``` cargo nextest run \ -p iota-graphql-e2e-tests \ -p iota-package-resolver ```
…s` (#7216) Generalize `Resolver::function_parameters` so that it returns the fully resolved function signature. Previously this function was used to infer transaction input layouts, but we also need roughly the same logic for returning a normalized move function. According to [changes](MystenLabs/sui@5024b1f#diff-76de243b84e1bcb523b9725574d3ae44530b9a49db102035ad19f2d8d6bb54c3). Fixes #7060 . Run ``` cargo nextest run -p iota-package-resolver ```
…nsactional test adapter (#7180) [run-ci] According to [changes](MystenLabs/sui@ae367c4#diff-7a132b89ef988a881b2c5d33b4cee85acb20e6be9c7fc645d26806d7ae307290). I as see we don’t have iota-indexer-alt-e2e tests and iota-mvr-graphql-e2e, so changes only touch iota-graphql-e2e- tests. Only these changes differ from Sui’s commit. I assume it’s because of the version differences in fastcrypto or async_graphql. To comply with how iota-graphql-rpc decodes the JSON cursor … this traces back to async_graphql = 7.0.7, which uses no padding for encoding/decoding. `Ok(Base64::encode(cursor)); ` This likely defaults to: - STANDARD base64 - with padding (=) - and possibly using the general character set (+ / /). But the decoder expects: - URL_SAFE_NO_PAD - no padding, using - and _ - matching what async_graphql and the RPC layer parse. ``` return Ok(base64::Engine::encode( &base64::engine::general_purpose::URL_SAFE_NO_PAD, cursor, )); ``` Fixes #7059 . - Enhancement (a non-breaking change which adds functionality) For iota-graphql-e2e- tests run: `cargo nextest run --features pg_integration` --------- Co-authored-by: Istvan Davorin Acs <[email protected]>
79f1ee0
to
be6f54c
Compare
# Description of change In [commit](058b493#diff-17cdfbdc54b5e6dd0eff37a911fbf44167d77ac8342b54ff6f41b8cccfca2671) some test names weren't following the changes from the original [changes list](MystenLabs/sui@778e78a#diff-000c960638af936148493636d55c8ea62676d2f051774239fc73e7fc1468bf32). To avoid any future confusion, these were fixed. ## Links to any relevant issues Adjusts #7078 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sc-platform
Issues related to the Smart Contract Platform group.
vm-language
Issues related to the VM & Language Team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Please write a summary of your changes and why you made them.
Links to any relevant issues
Be sure to reference any related issues by adding
fixes #(issue)
.How the change has been tested
Release Notes