Skip to content

refactor(light-client)!: rewrite binary to create test fixtures #7207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

refactor(light-client)!: rewrite binary to create test fixtures #7207

wants to merge 7 commits into from

Conversation

Alex6323
Copy link
Contributor

@Alex6323 Alex6323 commented Jun 3, 2025 •
edited
Loading

Description of change

  1. Renames the binary (BREAKING CHANGE).
  2. Creates the test fixtures from devnet checkpoints and summaries.
  3. Uses the historical checkpoint store instead of the REST API (which is not exposed)
  4. Improves fixture configuration by removing hard-coded checkpoint sequence numbers
  5. cleans up the config module

Links to any relevant issues

fixes #6825

How the change has been tested

  • Basic tests (linting, compilation, formatting, unit/integration tests)
  • Patch-specific tests (correctness, functionality coverage)
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

Release Notes

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@Alex6323 Alex6323 requested a review from a team as a code owner June 3, 2025 10:38
@vercel Vercel
Copy link

vercel bot commented Jun 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2025 10:22am
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2025 10:22am
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2025 10:22am
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2025 10:22am

@iota-ci iota-ci added dev-tools Issues related to the Developer Tools Team sc-platform Issues related to the Smart Contract Platform group. labels Jun 3, 2025
@thibault-martinez
Copy link
Member

Failing CI

Thoralf-M
Thoralf-M requested changes Jun 3, 2025
View reviewed changes
Copy link
Member

@Thoralf-M Thoralf-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/iotaledger/iota/blob/dev-tools/chore/remove-unused-binary/crates/iota-light-client/tests/README.md needs to be updated

@Alex6323 Alex6323 changed the title [light-client]!: rewrite binary to create test fixtures refactor(light-client)!: rewrite binary to create test fixtures Jun 12, 2025
Thoralf-M
Thoralf-M reviewed Jun 12, 2025
View reviewed changes
crates/iota-light-client/tests/README.md
1. `cargo run --release --all-features --bin iota start --force-regenesis --with-faucet --with-graphql`
2. Run `cargo run --bin generate-checkpoint-snapshots`
3. Replace data in tests according to generated checkpoints.
1. Modify the `SELECTED_EPOCHS` constant in `src/bin/update_fixtures.rs`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should it be modified?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thoralf-M Thoralf-M Thoralf-M requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
dev-tools Issues related to the Developer Tools Team sc-platform Issues related to the Smart Contract Platform group.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[light-client]: do we still need the generate_checkpoint_snapshots binary?
4 participants
@Alex6323 @thibault-martinez @Thoralf-M @iota-ci