upstream(consensus): Porting consensus related upstream changes #7275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
muXxer
approved these changes
Jun 10, 2025
…actions at startup #20974 (#7164) # Description of change Upstream change: Re-execute single-writer pending consensus transactions at startup (#20974) MystenLabs/sui@9595c00 (PR: MystenLabs/sui#20974) > Re-execute pending single writer transactions at startup > Do not wait forever for checkpoints to be rebuilt (this is thoroughly tested not to happen, but I realized that waiting forever here in prod does not actually buy us anything). ## Links to any relevant issues Resolves #6576. ## Type of change Choose a type of change, and delete any options that are not relevant. - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested CI Make sure to provide instructions for the maintainer as well as any relevant configurations. - [ ] Basic tests (linting, compilation, formatting, unit/integration tests) - [ ] Patch-specific tests (correctness, functionality coverage) ## Change checklist Tick the boxes that are relevant to your changes, and delete any items that are not. - [ ] I have followed the contribution guidelines for this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that new and existing unit tests pass locally with my changes ### Release Notes - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
…rently with consensus handling since there may be dependencies in either direction (#7173) # Description of change Port upstream change: Re-execution of pending certs must happen concurrently with consensus handling since there may be dependencies in either direction. (#21000) MystenLabs/sui@8a72297 (PR: MystenLabs/sui#21000) ## Links to any relevant issues Resolves #6579 ## Type of change Choose a type of change, and delete any options that are not relevant. - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested CI Make sure to provide instructions for the maintainer as well as any relevant configurations. - [ ] Basic tests (linting, compilation, formatting, unit/integration tests) - [ ] Patch-specific tests (correctness, functionality coverage) ## Change checklist Tick the boxes that are relevant to your changes, and delete any items that are not. - [ ] I have followed the contribution guidelines for this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that new and existing unit tests pass locally with my changes ### Release Notes - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
# Description of change Upstream change: make SubmitToConsensus trait non-async (#21016) MystenLabs/sui@df08cb2 (PR: MystenLabs/sui#21016) ## Links to any relevant issues Resolves #6580 ## Type of change Choose a type of change, and delete any options that are not relevant. - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested CI Make sure to provide instructions for the maintainer as well as any relevant configurations. - [ ] Basic tests (linting, compilation, formatting, unit/integration tests) - [ ] Patch-specific tests (correctness, functionality coverage) ## Change checklist Tick the boxes that are relevant to your changes, and delete any items that are not. - [ ] I have followed the contribution guidelines for this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that new and existing unit tests pass locally with my changes ### Release Notes - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
…ock execution (#7177) # Description of change Upstream change: Sending to the subscription handler should not block execution (#21100) MystenLabs/sui@a6b1d1d (PR: MystenLabs/sui#21100) > Subscriptions are already not 100% reliable, and this allows a slow > subscription handler to block execution indefinitely, which we don't > want. ## Links to any relevant issues fixes #6583 ## Type of change Choose a type of change, and delete any options that are not relevant. - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested CI Make sure to provide instructions for the maintainer as well as any relevant configurations. - [ ] Basic tests (linting, compilation, formatting, unit/integration tests) - [ ] Patch-specific tests (correctness, functionality coverage) ## Change checklist Tick the boxes that are relevant to your changes, and delete any items that are not. - [ ] I have followed the contribution guidelines for this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that new and existing unit tests pass locally with my changes ### Release Notes - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
…erflow instead of panic (#7183) # Description of change Upstream change: `change MockConsensusClient to return error on overflow instead of panic (#21284)` MystenLabs/sui@0a4e0ab. Depends on [PR 7177](#7177) ## Links to any relevant issues Fixes #6585 ## Type of change Choose a type of change, and delete any options that are not relevant. - Bug fix (a non-breaking change which fixes an issue) ## How the change has been tested Describe the tests that you ran to verify your changes. CI ### Infrastructure QA (only required for crates that are maintained by @iotaledger/infrastructure) - [ ] Synchronization of the indexer from genesis for a network including migration objects. - [ ] Restart of indexer synchronization locally without resetting the database. - [ ] Restart of indexer synchronization on a production-like database. - [ ] Deployment of services using Docker. - [ ] Verification of API backward compatibility. ## Change checklist Tick the boxes that are relevant to your changes, and delete any items that are not. - [ ] I have followed the contribution guidelines for this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that new and existing unit tests pass locally with my changes ### Release Notes - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
…heckpoint order (#7185) # Description of change Upstream change: rpc-index: ensure indexing updates are committed in checkpoint order #20895 MystenLabs/sui@873c865 > Rework how rpc-indexes are updated by having the updates continue to be > prepared out-of-order, but then committing them to the DB in checkpoint > order. Only rest-indexes instead of rpc in our code. ## Links to any relevant issues ## Type of change Choose a type of change, and delete any options that are not relevant. - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested CI Make sure to provide instructions for the maintainer as well as any relevant configurations. - [ ] Basic tests (linting, compilation, formatting, unit/integration tests) - [ ] Patch-specific tests (correctness, functionality coverage) ### Infrastructure QA (only required for crates that are maintained by @iotaledger/infrastructure) - [ ] Synchronization of the indexer from genesis for a network including migration objects. - [ ] Restart of indexer synchronization locally without resetting the database. - [ ] Restart of indexer synchronization on a production-like database. - [ ] Deployment of services using Docker. - [ ] Verification of API backward compatibility. ## Change checklist Tick the boxes that are relevant to your changes, and delete any items that are not. - [ ] I have followed the contribution guidelines for this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that new and existing unit tests pass locally with my changes ### Release Notes - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
…7166) # Description of change Port of upstream change: MystenLabs/sui@277c398 > Right now consensus latency is ~320ms on average, but the median is read > to be higher. I believe this is because the buckets are too coarse. > Switching to finer grained buckets should improve the precision. ## Links to any relevant issues Fixes #6581 ## Type of change Choose a type of change, and delete any options that are not relevant. - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested CI Make sure to provide instructions for the maintainer as well as any relevant configurations. - [ ] Basic tests (linting, compilation, formatting, unit/integration tests) - [ ] Patch-specific tests (correctness, functionality coverage) ### Release Notes - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
# Description of change Upstream change of MystenLabs/sui@c29efa3#diff-d16f175b0378e5a7ae847a4d6887837130f10816a67aa8346a55ed5a1e177fa7 > This PR > - Reduces logging vebosity in general > - Reduce log levels for antithesis tests ## Links to any relevant issues Resolves #6574 ## Type of change Choose a type of change, and delete any options that are not relevant. - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested CI Make sure to provide instructions for the maintainer as well as any relevant configurations. - [ ] Basic tests (linting, compilation, formatting, unit/integration tests) - [ ] Patch-specific tests (correctness, functionality coverage) ## Change checklist Tick the boxes that are relevant to your changes, and delete any items that are not. - [ ] I have followed the contribution guidelines for this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that new and existing unit tests pass locally with my changes ### Release Notes - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
VorobyevIlya
force-pushed
the
consensus/upstream-changes/sprint-21
branch
from
b011ad8 to
be95db0
Compare
VorobyevIlya
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR contains a batch of node-team related upstream changes. The changes have been individually reviewed before squash-merging. None of them modify protocol parameters, so a new protocol version is not necessary.
This PR should be rebased on top of develop without squashing as it already contains squashed PRs.
Links to any relevant issues
List of included PRs:
How the change has been tested
CI, local network
Release Notes