Skip to content

upstream(faucet): add user-agent header for incoming requests #7277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 11, 2025

Conversation

thibault-martinez
Copy link
Member

@thibault-martinez thibault-martinez commented Jun 9, 2025

Description of change

This PR adds the user-agent header for the faucet requests to keep track which requests come from where.
The CLI gets updated to make usage of this header when requesting a token via sui client faucet.

Links to any relevant issues

Fixes #4913
Upstream MystenLabs/sui#20525

How the change has been tested

  • Basic tests (linting, compilation, formatting, unit/integration tests)
  • Patch-specific tests (correctness, functionality coverage)
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

Release Notes

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@thibault-martinez thibault-martinez requested review from a team as code owners June 9, 2025 09:16
Copy link

vercel bot commented Jun 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2025 2:29pm
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2025 2:29pm
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2025 2:29pm
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Jun 11, 2025 2:29pm

@iota-ci iota-ci added dev-tools Issues related to the Developer Tools Team sc-platform Issues related to the Smart Contract Platform group. labels Jun 9, 2025
@Thoralf-M
Copy link
Member

test_faucet fails

@thibault-martinez thibault-martinez merged commit 2a37591 into develop Jun 11, 2025
36 checks passed
@thibault-martinez thibault-martinez deleted the upstream/faucet-add-user-agent-header branch June 11, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-tools Issues related to the Developer Tools Team sc-platform Issues related to the Smart Contract Platform group.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(iota-faucet): add user-agent header for incoming requests
4 participants