Skip to content

fix(consensus): Timeout when establishing a subscription connection #7292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

piotrm50
Copy link
Contributor

Description of change

Add a timeout when establishing a subscription connection to a peer takes too much time. This is done to avoid potentially hanging on this part.

Links to any relevant issues

Partly resolves #ana

How the change has been tested

CI, local network

  • Basic tests (linting, compilation, formatting, unit/integration tests)
  • Patch-specific tests (correctness, functionality coverage)
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

Release Notes

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@piotrm50 piotrm50 added this to the v1.3.x - protocol v9 milestone Jun 10, 2025
@piotrm50 piotrm50 self-assigned this Jun 10, 2025
@piotrm50 piotrm50 requested a review from a team as a code owner June 10, 2025 07:18
@piotrm50 piotrm50 added the consensus Issues related to the Core Consensus team label Jun 10, 2025
Copy link

vercel bot commented Jun 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Jun 10, 2025 7:18am
apps-ui-kit ⬜️ Ignored (Inspect) Jun 10, 2025 7:18am
rebased-explorer ⬜️ Ignored (Inspect) Jun 10, 2025 7:18am
wallet-dashboard ⬜️ Ignored (Inspect) Jun 10, 2025 7:18am

@piotrm50 piotrm50 merged commit a9ba2ee into develop Jun 11, 2025
36 checks passed
@piotrm50 piotrm50 deleted the consensus/fix/add-subscribe-block-timeout branch June 11, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus Issues related to the Core Consensus team core-protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants