Skip to content

upstream(node): core: factor out parallel live object indexing #7306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

muXxer
Copy link
Contributor

@muXxer muXxer commented Jun 10, 2025

Description of change

  • Upstream range: [v1.35.4, v1.36.2)
  • Port commit: MystenLabs/sui@6159973
  • Descriptions from commits
    Factor out the parallel live object indexing, used for initializing the
    rest indexes, into more general purpose and reusable logic.

Links to any relevant issues

Part of #3990

  • Basic tests (linting, compilation, formatting, unit/integration tests)
  • Patch-specific tests (correctness, functionality coverage)
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

Factor out the parallel live object indexing, used for initializing the rest indexes, into more general purpose and reusable logic.
@muXxer muXxer requested review from a team as code owners June 10, 2025 15:33
Copy link

vercel bot commented Jun 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Jun 10, 2025 3:33pm
apps-ui-kit ⬜️ Ignored (Inspect) Jun 10, 2025 3:33pm
rebased-explorer ⬜️ Ignored (Inspect) Jun 10, 2025 3:33pm
wallet-dashboard ⬜️ Ignored (Inspect) Jun 10, 2025 3:33pm

@iota-ci iota-ci added core-protocol node Issues related to the Core Node team labels Jun 10, 2025
Copy link
Contributor

@semenov-vladyslav semenov-vladyslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for one very weird place. IMHO, should be addressed.

Copy link
Contributor

@semenov-vladyslav semenov-vladyslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current version of the code doesn't make any breaking changes, just make the existing code more generic. The questions not answered will be investigated in another issue.

@muXxer muXxer merged commit 768e296 into core-node/upstream-changes/mainnet-1.36.2-1.37.4 Jun 11, 2025
57 of 58 checks passed
@muXxer muXxer deleted the node/upstream-v1.35-1.36/6159973 branch June 11, 2025 07:43
muXxer added a commit that referenced this pull request Jun 11, 2025
# Description of change

- Upstream range: [v1.35.4, v1.36.2)
- Port commit:
MystenLabs/sui@6159973
- Descriptions from commits
Factor out the parallel live object indexing, used for initializing the
rest indexes, into more general purpose and reusable logic.

## Links to any relevant issues

Part of #3990 

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [ ] Patch-specific tests (correctness, functionality coverage)
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have checked that new and existing unit tests pass locally with
my changes
muXxer added a commit that referenced this pull request Jun 11, 2025
# Description of change

- Upstream range: [v1.35.4, v1.36.2)
- Port commit:
MystenLabs/sui@6159973
- Descriptions from commits
Factor out the parallel live object indexing, used for initializing the
rest indexes, into more general purpose and reusable logic.

## Links to any relevant issues

Part of #3990 

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [ ] Patch-specific tests (correctness, functionality coverage)
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have checked that new and existing unit tests pass locally with
my changes
muXxer added a commit that referenced this pull request Jun 11, 2025
…ainnet-1.36.2 to mainnet-1.37.4 (#7304)

# Description of change

This PR contains a batch of node-team related upstream changes. The
changes have been individually reviewed before squash-merging. None of
them modify protocol parameters, so a new protocol version is not
necessary.

This PR should be rebased on top of develop without squashing as it
already contains squashed PRs.

## Links to any relevant issues

List of included PRs:

- #6964
- #6974
- #6977
- #7264
- #7266
- #7282
- #7306
- #7320

List of included upstream commits:

-
MystenLabs/sui@cf2a573
-
MystenLabs/sui@7c517e7
-
MystenLabs/sui@5fd33ae
-
MystenLabs/sui@832da30
-
MystenLabs/sui@65b02e2
-
MystenLabs/sui@16f2683
-
MystenLabs/sui@6159973
-
MystenLabs/sui@4ad76b5
-
MystenLabs/sui@814af2a

## Type of change

- Enhancement (a non-breaking change which adds functionality)

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [ ] Patch-specific tests (correctness, functionality coverage)

### Release Notes

- [ ] Protocol:
- [x] Nodes (Validators and Full nodes):
- compaction: enable periodic compaction of individual SST files by
default
- [ ] Indexer:
- [ ] JSON-RPC:
- [ ] GraphQL:
- [ ] CLI:
- [ ] Rust SDK:
- [ ] REST API:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-protocol node Issues related to the Core Node team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants