Conversation
Liuhaai
commented
Apr 10, 2024
| github.com/deckarep/golang-set v1.7.1 // indirect | ||
| github.com/dustinxie/gmsm v1.4.0 | ||
| github.com/ethereum/go-ethereum v1.10.4 | ||
| github.com/ethereum/go-ethereum v1.13.5-0.20240410090245-9dcf8aae4742 |
Member
Author
There was a problem hiding this comment.
I used the lastest commit in the master branch for testing, since geth v1.13.15 hasn't been released yet.
Member
Author
There was a problem hiding this comment.
For prod usage, we might wait until geth v1.13.15 is released
Contributor
There was a problem hiding this comment.
can we just use v1.13.12 (which is the Cancun release version we use for iotex-core)
Does v1.13.12 fix this memory issue?
Member
Author
There was a problem hiding this comment.
no. pls check the geth's pr ethereum/go-ethereum@ab49f22, which isn't included in v1.13.14
Merged
Member
Author
|
pls check #40 before merging this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR purpose: optimization mem allocation by bumping crypto library in Geth
The memory allocation of pubkey deserialization is reduced by 70% in the PR
The results of benchmark test after and before commit