libbpf-tools/syscount,memleak: Add metric output support #5281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekyooo
requested review from
brendangregg,
goldshtn,
davemarchevsky,
drzaeus77,
yonghong-song and
4ast
as code owners
|
Changes:
Thank you. |
Allow callers to handle errors via return value instead of parsing the buffer.
Add --output option to syscount to print system call metrics in Line Protocol format for time-series analysis. Update syscount_example.txt with usage, examples, and a visualization guide for InfluxDB/Grafana. Add images for basic, process, latency, and combined dashboard modes.
Add --output option to memleak to print outstanding allocation metrics in Line Protocol format. Update memleak_example.txt with usage, examples, and a visualization guide for InfluxDB/Grafana. Add images for allocation size, count, and combined dashboard.
Add print_metric() to trace_helpers to streamline metric output. - Print metrics in Line Protocol format for time-series compatibility. - Design the utility to support extensible formats. - Apply the API usage to syscount and memleak to remove duplicates.
Add --output option to biotop to print system call metrics in Line Protocol format for time-series analysis. Include biotop_example.txt with usage, examples, and visualization guide for tools like InfluxDB and Grafana. Add images for I/O and Latency modes.
|
Changes:
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series adds support for metric output to syscount, memleak and biotop starting with the Line Protocol format to enable time-series visualization using tools like InfluxDB and Grafana.
To support future extensibility, the output logic is abstracted via a shared utility in trace_helpers. The design encourages adding other formats down the line.
Why time-series metrics?
Why Line Protocol first?
It's widely adopted in time-series systems, easy to parse, and integrates seamlessly with common stacks like Telegraf + InfluxDB.
This version is intended to share the concept and direction. Feedback is welcome before final polishing.
Thank you.