Skip to content

Conversation

@zfergus
Copy link
Member

@zfergus zfergus commented Sep 6, 2024

Description

Replace the use_convergent_formulation flag in Collisions with two flags: use_area_weighting and use_improved_max_approximator. Move the physical barrier rescaling from collision weights into the BarrierPotential using a flag use_physcial_barrier.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Existing unit tests

Test Configuration:

  • OS and version: macOS 14.6.1
  • Compile and version: Apple clang version 15.0.0

Checklist:

  • I have followed the project style guide
  • My code follows the clang-format style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 95.50562% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.31%. Comparing base (416cdd4) to head (93958ac).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/ipc/friction/collisions/friction_collision.cpp 76.92% 3 Missing ⚠️
src/ipc/collisions/collisions.cpp 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   96.12%   96.31%   +0.19%     
==========================================
  Files         102      102              
  Lines        7584     7602      +18     
==========================================
+ Hits         7290     7322      +32     
+ Misses        294      280      -14     
Flag Coverage Δ
unittests 96.31% <95.50%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zfergus zfergus merged commit 86f1db3 into main Sep 8, 2024
@zfergus zfergus deleted the expose-improve-max-approx branch September 8, 2024 16:57
@zfergus zfergus added this to the v1.3.1 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants