Skip to content

Adhesion #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 47 commits into from
Nov 9, 2024
Merged

Adhesion #85

merged 47 commits into from
Nov 9, 2024

Conversation

zfergus
Copy link
Member

@zfergus zfergus commented Dec 15, 2023

Description

Implement the adhesion potentials from "Augmented Incremental Potential Contact for Sticky Interactions" [Fang et al. 2023].

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • New unit tests

Test Configuration:

  • OS and version: macOS 14.2
  • Compile and version: Apple clang version 15.0.0

Checklist:

  • I have followed the project style guide
  • My code follows the clang-format style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@zfergus zfergus added the enhancement New feature or request label Dec 15, 2023
@zfergus zfergus added this to the v1.3.0 milestone Dec 15, 2023
@zfergus zfergus changed the title Add normal adhesion functions Adhesion Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: Patch coverage is 97.45354% with 37 lines in your changes missing coverage. Please review.

Project coverage is 96.72%. Comparing base (9568030) to head (2feb88c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ipc/collisions/normal/normal_collision.cpp 30.00% 7 Missing ⚠️
src/ipc/potentials/tangential_potential.cpp 96.74% 7 Missing ⚠️
...c/ipc/potentials/tangential_adhesion_potential.cpp 40.00% 6 Missing ⚠️
...c/ipc/potentials/tangential_adhesion_potential.hpp 57.14% 3 Missing ⚠️
...pc/collisions/normal/normal_collisions_builder.cpp 95.12% 2 Missing ⚠️
src/ipc/collisions/tangential/vertex_vertex.cpp 83.33% 2 Missing ⚠️
src/ipc/potentials/barrier_potential.cpp 88.88% 2 Missing ⚠️
src/ipc/tangent/tangent_basis.cpp 99.76% 2 Missing ⚠️
src/ipc/collisions/normal/normal_collisions.cpp 96.66% 1 Missing ⚠️
src/ipc/collisions/tangential/edge_edge.hpp 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   96.31%   96.72%   +0.41%     
==========================================
  Files         102      109       +7     
  Lines        7600     7730     +130     
==========================================
+ Hits         7320     7477     +157     
+ Misses        280      253      -27     
Flag Coverage Δ
unittests 96.72% <97.45%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zfergus zfergus modified the milestones: v1.3.0, v1.3.1 Jul 24, 2024
@zfergus zfergus modified the milestones: v1.3.1, v1.4.0 Nov 5, 2024
@zfergus zfergus marked this pull request as ready for review November 9, 2024 18:15
@zfergus zfergus merged commit 33e5dd3 into main Nov 9, 2024
32 checks passed
@zfergus zfergus deleted the adhesion branch November 9, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant