Bun 1.4.2: pin, types, pointer narrowing, renderer NODE_ENV per command - #25
Merged
Merged
Conversation
…eeps pointer returns typed as Pointer
… ship production React
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed in Bun 1.4 that touches Bunmaska
cstringreturns are plain strings andnullfor NULL; our threecstringsymbols already calltoString()on the value, so nothing changes. bun-types 1.4 widensFFIType.ptrreturns toPointer | bigint | null; the runtime still returns numbers (probed on 1.4.2), so a narrowingdlopenwrapper insrc/main/platform/dlopen.tskeeps every call site typed as before. 36 loader files rewired mechanically."jsx": "react-jsx"now emitsjsx, notjsxDEV, unlessNODE_ENV=developmentis defined. Our renderer build used to forcedevelopmentas a workaround; it now definesNODE_ENVper command (dev= development,build= production). Works the same on Bun 1.3. Packaged apps stop shipping the React development runtime.Bun.$globs, nofs.rmdir recursive, no Temporal, bunfig parses under the strict TOML parser, lockfile stays v1).Verification
bun run validategreen locally on Bun 1.4.2 (1623 tests). Website builds..bun-versionbumped,setup-bunreads it).engines.bunstays>=1.3.0.Noted, not done
bun test --isolateon the unit suite finds two tests that only pass because the ObjC class registration one-shot guard is module state while the class itself is process state. MakingdefineObjcClassidempotent would let us adopt--isolatefor unit tests.