feat: add SessionExchange support and optimize blocking checks#50
Draft
feat: add SessionExchange support and optimize blocking checks#50
Conversation
- implement BlockedBlockstore wrapper for blockstore operations - implement BlockedExchange with SessionExchange support - add BlockedFetcher for session-level blocking - optimize BlockService to delegate checks to wrapped components - add compile-time type assertions for all interfaces fixes #34
lidel
added a commit
to ipfs/boxo
that referenced
this pull request
Aug 31, 2025
- use blockservice.NewSession for automatic session reuse - properly enforce denylist checks via wrapped blockstore/exchange - improve performance with request-level session batching requires ipfs-shipyard/nopfs#50 fixes #458 fixes ipfs/kubo#10361
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Aug 31, 2025
- nopfs: SessionExchange support and optimized blocking checks ipfs-shipyard/nopfs#50 - boxo: restored session usage in CAR streaming with proper blocking ipfs/boxo#1019 fixes #10361
- test blockstore, exchange, and blockservice wrappers - add test helpers and mocks
plugin is now built into kubo v0.24.0+
- include ipfs/ tests in CI workflow - update to go 1.24 for compatibility
lidel
force-pushed
the
fix-blockservice-getters
branch
from
c8da810 to
16ea529
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This wip experimentation, not ready for review yet.
This PR aims to address problem from #34 and also..
BlockedBlockstorewrapper for blockstore operationsBlockedExchangewithSessionExchangesupportBlockedFetcherfor session-level blockingBlockServiceto delegate checks to wrapped componentsI'm mainly depending on e2e tests in Kubo (
go test -v ./test/cli -run "TestContentBlocking") in PR that integrates this PR and ipfs/boxo#1019