Bump min Python version from 3.5.4 to 3.6.2#262
Merged
ntninja merged 4 commits intoipfs-shipyard:masterfrom Apr 9, 2021
Merged
Bump min Python version from 3.5.4 to 3.6.2#262ntninja merged 4 commits intoipfs-shipyard:masterfrom
ntninja merged 4 commits intoipfs-shipyard:masterfrom
Conversation
c0llab0rat0r
force-pushed
the
require-python-36
branch
4 times, most recently
from
d148411 to
c85cd3c
Compare
Contributor
Author
c0llab0rat0r
force-pushed
the
require-python-36
branch
from
c85cd3c to
d3a6210
Compare
Contributor
Author
|
Whitespace commit wasn't a failing style check; it was to tickle the build to rerun a build job that had a transient failure related to docker. |
ntninja
requested changes
Apr 9, 2021
Contributor
ntninja
left a comment
ntninja
left a comment
There was a problem hiding this comment.
Found a couple of things (mostly stylistic though). Also thanks for fixing all the spelling mistakes!
c0llab0rat0r
force-pushed
the
require-python-36
branch
2 times, most recently
from
41b517d to
1d9be47
Compare
c0llab0rat0r
force-pushed
the
require-python-36
branch
from
1d9be47 to
26f0172
Compare
Contributor
Author
|
I believe I've incorporated all of the review feedback, except for the refactors related to Would you be ok with that refactor being in a separate PR, or would you like it addressed here? |
ntninja
approved these changes
Apr 9, 2021
Contributor
ntninja
left a comment
ntninja
left a comment
There was a problem hiding this comment.
Very much appreciated! Thank you!
| AnyPath = ty.TypeVar("AnyPath", str, PathLike_str, bytes, PathLike_bytes) | ||
|
|
||
| path_types = (str, bytes, os.PathLike,) | ||
| path_obj_types = (os.PathLike,) |
Contributor
There was a problem hiding this comment.
That would be great too! I just happened to see this and thought I'd add some feedback in case it's easy to do.
c0llab0rat0r
added a commit
to c0llab0rat0r/py-ipfs-http-client
that referenced
this pull request
Apr 9, 2021
c0llab0rat0r
added a commit
to c0llab0rat0r/py-ipfs-http-client
that referenced
this pull request
Apr 9, 2021
c0llab0rat0r
added a commit
to c0llab0rat0r/py-ipfs-http-client
that referenced
this pull request
Apr 9, 2021
c0llab0rat0r
added a commit
to c0llab0rat0r/py-ipfs-http-client
that referenced
this pull request
Apr 10, 2021
c0llab0rat0r
added a commit
to c0llab0rat0r/py-ipfs-http-client
that referenced
this pull request
Apr 10, 2021
c0llab0rat0r
added a commit
to c0llab0rat0r/py-ipfs-http-client
that referenced
this pull request
Apr 14, 2021
c0llab0rat0r
added a commit
to c0llab0rat0r/py-ipfs-http-client
that referenced
this pull request
Apr 15, 2021
ntninja
pushed a commit
that referenced
this pull request
Apr 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduction in scope of #260, since this client is pledged to support Python 3.6 thru its EOL.
#261 should be merged before this PR is.