Fix authentication bug with httpx usage#289
Open
c0llab0rat0r wants to merge 3 commits intoipfs-shipyard:masterfrom
Open
Fix authentication bug with httpx usage#289c0llab0rat0r wants to merge 3 commits intoipfs-shipyard:masterfrom
c0llab0rat0r wants to merge 3 commits intoipfs-shipyard:masterfrom
Conversation
… to StatusError class; change PartialErrorResponse to inherit from Error instead of ErrorResponse due to lack of status code
c0llab0rat0r
changed the title
Contributor
Author
|
@ntninja this is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And:
status_codeproperty toStatusErrorclassPartialErrorResponseto inherit fromErrorinstead ofErrorResponsedue to lack of success status code availablilty at call site throwingPartialErrorResponseThis PR is an alternative to #285.