generated from ipfs/ipfs-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 120
session: add new session package #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Jorropo
wants to merge
1
commit into
main
Choose a base branch
from
session/v3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,94 @@ | ||
// session implements a finality independent session system. It let session producers transparently integrate with any session consumer without prequired shared state. | ||
// A session bundles a logical set of related requests, it let download clients more efficiently send requests in the network, the assumption is that the same nodes should host most of the data in the related requests. | ||
// To create a new session use [ContextWithSession], compatible consumers like bitswap will automatically pick it up from the context. | ||
package session | ||
|
||
import ( | ||
"context" | ||
"sync" | ||
) | ||
|
||
type contextKey struct{} | ||
|
||
// ContextWithSession attach a session to the context, it may reuse an existing session if one already exists in the context. | ||
// The context must be canceled in some way to ensure all sessions are cleaned up. | ||
func ContextWithSession(ctx context.Context) context.Context { | ||
if _, ok := getRegistryFromContext(ctx); ok { | ||
return ctx | ||
} | ||
|
||
return context.WithValue(ctx, contextKey{}, &sessionRegistry{sesCtx: ctx}) | ||
} | ||
|
||
// sessionRegistry is meant for session consumers. | ||
// This type allows session consumers to inject their own session object within an existing context. | ||
// This exists as it allows to satisfy theses two requirements: | ||
// - Session producers must not need to hold some prexisting session factory object to inject into their contextes. | ||
// - Session consumers must be able to not to maintain any state to track inflight sessions, instead they can store their session object in the sessionRegistry and rely on GC to cleanup. | ||
// It is threadsafe. | ||
type sessionRegistry struct { | ||
sesCtx context.Context | ||
lk sync.Mutex // protects sessions | ||
sessions map[any]any | ||
} | ||
|
||
func getRegistryFromContext(ctx context.Context) (_ *sessionRegistry, ok bool) { | ||
r := ctx.Value(contextKey{}) | ||
if r == nil { | ||
return nil, false | ||
} | ||
|
||
rr, ok := r.(*sessionRegistry) | ||
return rr, ok | ||
} | ||
|
||
// Get attempt to fetch the session for the producer. | ||
func Get[P comparable, S any](ctx context.Context, producer P) (session S, ok bool) { | ||
r, ok := getRegistryFromContext(ctx) | ||
if !ok { | ||
return | ||
} | ||
|
||
r.lk.Lock() | ||
s, ok := r.sessions[producer] | ||
r.lk.Unlock() | ||
if !ok { | ||
return | ||
} | ||
|
||
ss, ok := s.(S) | ||
return ss, ok | ||
} | ||
|
||
// GetOrCreate atomically fetch a session from the context, if none is present the create function is invoked and saved in the context. | ||
// All contextes scoped to the first [ContextWithSession] will be able to reuse this session. | ||
// create must not block. | ||
// sessionContext is scoped to the session, it allows consumers to cleanup session scoped goroutines or other similar things. | ||
func GetOrCreate[P comparable, S any](ctx context.Context, producer P, create func(sessionContext context.Context) (session S, ok bool)) (session S, ok bool) { | ||
r, ok := getRegistryFromContext(ctx) | ||
if !ok { | ||
return | ||
} | ||
|
||
r.lk.Lock() | ||
defer r.lk.Unlock() | ||
s, ok := r.sessions[producer] | ||
if ok { | ||
if ss, ok := s.(S); ok { | ||
return ss, true | ||
} | ||
// Overwrite with a new session if types don't match ? | ||
} | ||
|
||
ss, ok := create(r.sesCtx) | ||
if !ok { | ||
return | ||
} | ||
|
||
if r.sessions == nil { | ||
r.sessions = make(map[any]any, 1) | ||
} | ||
r.sessions[producer] = ss | ||
|
||
return ss, true | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.