bitswap/httpnet: Disconnect peers after client errors #919
+268
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a configuration option to disconnect from peers when they return too many errors of type client (404s, Gone, Forbidden, Moved, Redirect. etc). in a row. Such peers with low hit rates on the blocks we ask for must not perpetually receive optimistic requests and are "disconnected" accordingly if they cross the threshold (100 by default). They will be recontacted if a record pointing to them appears. The implementation logs the errors at the end of processing the responses for a wantlist (that is, once per wantlist), the tracking only locks the map on connect/disconnect events, allowing for low lock contention operations.
hsanjuan
commented
May 15, 2025
hsanjuan
force-pushed
the
bitswap-httpnet-disconnect-eventually
branch
from
7289141 to
354981e
Compare
gammazero
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a configuration option to disconnect from peers when they return too many errors of type client (404s, Gone, Forbidden, Moved, Redirect. etc). in a row.
Such peers with low hit rates on the blocks we ask for must not perpetually receive optimistic requests and are "disconnected" accordingly if they cross the threshold (100 by default). They will be recontacted if a record pointing to them appears.
The implementation logs the errors at the end of processing the responses for a wantlist (that is, once per wantlist), the tracking only locks the map on connect/disconnect events, allowing for low lock contention operations.
cc #918