Skip to content

refactor: use a more efficient querying method #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025
Merged

Conversation

pullmerge
Copy link
Contributor

There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.

@pullmerge pullmerge requested review from lidel and a team as code owners May 21, 2025 09:07
Copy link

welcome bot commented May 21, 2025

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@hsanjuan
Copy link
Contributor

User has added similar PRs to other projects, probably fishing for airdrops.

@hsanjuan hsanjuan added the kind/generated This issue might have been automatically generated label May 22, 2025
@benma
Copy link

benma commented May 22, 2025

@hsanjuan do you know of an active airdrop that is causing all these PRs?

Copy link

It seems this issue might have been automatically generated. To help us address it effectively, please provide additional details.

We value the use of LLMs for code generation and welcome your contributions but please ensure your submission is of such quality that a maintainer will spend less time reviewing it than implementing it themselves. Verify the code functions correctly and meets our standards. If your change requires tests, kindly include them and ensure they pass.

If no further information is provided, the issue will be automatically closed in 7 days. Thank you for your understanding and for aiding us in maintaining quality contributions!

@github-actions github-actions bot added the need/author-input Needs input from the original author label May 23, 2025
@pullmerge pullmerge changed the title refactor: use slices.Contains to simplify code refactor: use a more efficient querying method May 23, 2025
@gammazero gammazero added skip/changelog and removed need/author-input Needs input from the original author labels May 27, 2025
@gammazero gammazero merged commit 3b7d580 into ipfs:main May 27, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/generated This issue might have been automatically generated skip/changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants