Skip to content

Deep Dive Report Back: Reproducible CIDs#130

Merged
alanshaw merged 4 commits intomasterfrom
deep-dive-reproducible-cids
Jul 4, 2019
Merged

Deep Dive Report Back: Reproducible CIDs#130
alanshaw merged 4 commits intomasterfrom
deep-dive-reproducible-cids

Conversation

@lidel
Copy link
Copy Markdown
Member

@lidel lidel commented Jun 29, 2019

@lidel and @drbh around 14:35:

@lidel lidel requested review from alanshaw and drbh June 29, 2019 17:35
@daviddias daviddias added the DEEP DIVES Related to the deep dives activity label Jul 3, 2019
Copy link
Copy Markdown
Contributor

@drbh drbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alanshaw
Copy link
Copy Markdown
Member

alanshaw commented Jul 3, 2019

@lidel / @drbh any chance you can fix these conflicts?

@lidel
Copy link
Copy Markdown
Member Author

lidel commented Jul 3, 2019

@alanshaw done

Copy link
Copy Markdown
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lidel, @drbh ❤️ 🚀

@alanshaw alanshaw merged commit dccfa74 into master Jul 4, 2019
@alanshaw alanshaw deleted the deep-dive-reproducible-cids branch July 4, 2019 07:51
@drbh
Copy link
Copy Markdown
Contributor

drbh commented Jul 4, 2019

started a repo with a revive add option here: ipfs/kubo@master...drbh:force-default-params

@lidel
Copy link
Copy Markdown
Member Author

lidel commented Jul 8, 2019

@drbh that's really cool!

Consider submitting a [wip] or Draft PR, so we have a place to discuss implementation details and gather early feedback there :)

@drbh
Copy link
Copy Markdown
Contributor

drbh commented Jul 13, 2019

Added a WIP PR here ipfs/kubo#6509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DEEP DIVES Related to the deep dives activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants