-
Notifications
You must be signed in to change notification settings - Fork 127
test: use stubs instead of http in AbortSignal tests #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self review
if (options.signal?.aborted === true) { | ||
this.log.trace('session idle, signal aborted') | ||
return | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@achingbrain this makes debugging a little easier I think.. I'm fine to remove it, but it helped me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough
Just cleaning up some tests to address PR comment in previous PR.
Related: #776