fix: trustless gateway returned blocks can be limited #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alex Potsides <[email protected]>
Co-authored-by: Alex Potsides <[email protected]>
Co-authored-by: Alex Potsides <[email protected]>
Co-authored-by: Alex Potsides <[email protected]>
Co-authored-by: Alex Potsides <[email protected]>
use lowercase for logs; sentence case for error messages
|
FYI all of the requested changes have been made. lmk if I missed something. I'll look over all the code again now |
SgtPooki
commented
May 15, 2025
packages/block-brokers/src/trustless-gateway/trustless-gateway.ts
Outdated
Show resolved
Hide resolved
| * If the response contains a content-length header greater than the limit or the actual bytes returned are greater than | ||
| * the limit, an error is thrown. | ||
| */ | ||
| export async function limitedResponse (response: Response, byteLimit: number, options?: LimitedResponseOptions): Promise<Uint8Array> { |
There was a problem hiding this comment.
I left the property name here as byteLimit but could change to maxSize if we want.. leaving for now
lidel
reviewed
May 16, 2025
packages/block-brokers/src/trustless-gateway/trustless-gateway.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
fix: trustless gateway returned blocks can be limited
Description
Adds a new utility function
limitedResponsethat ensures the response body is less than a given byte limit.This is done by:
content-lengthheader is less than the limit, if not, an error is thrown.Fixes #790
Notes & open questions
Change checklist