refactor: migrate icons to typescript - #2397
Merged
Merged
Conversation
SgtPooki
commented
Aug 13, 2025
SgtPooki
left a comment
SgtPooki
left a comment
Member
Author
There was a problem hiding this comment.
self review. git CLI showed these files as renamed and not changed.. github apparently cannot.
| @@ -1,5 +1,5 @@ | |||
| import { CID } from 'multiformats/cid' | |||
| import { useState, useEffect, useCallback, type FC } from 'react' | |||
| import React, { useState, useEffect, useCallback, type FC } from 'react' | |||
Member
Author
There was a problem hiding this comment.
we are required to import React as global import in .jsx/.tsx files on react 16
Collaborator
|
🎉 This PR is included in version 4.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates all icons to typescript by upgrading svgr and updating parameters so generated icons are in the format we need.
Also:
Replaces #2390
PartOf #2349