chore: use fetch for range conformance tests #937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returning 206 causes Chrome to error with "File wasn't available on site" which then also breaks playwright. Instead override 206 to 200 and skip storing the partial response in the response cache. In the conformance suite we translate back to 206 so the response is as expected. Enables all single-range conformance tests.
achingbrain
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a range header is detected, use an in-page fetch invocation to run the test, this way it will be handled by the service worker and not trigger https://issues.chromium.org/issues/469788775
Enables all single, multi and full-range conformance tests.
Change checklist