Allow the car binary to provide a version. - #645
Merged
Merged
Conversation
This is done by running `go generate` before `go build`.
| @@ -0,0 +1 @@ | |||
| v2.x.x-unknown | |||
Contributor
There was a problem hiding this comment.
Shouldn't this be set to the latest tagged version, which is currently v2.16.0?
Member
Author
There was a problem hiding this comment.
It's a placeholder that allows go run ... to work.
in general, go generate will update this so that the result of builds will have a correct version. Since there are both v1 and v2 tags that will apply, i think it's going to be cleaner to not keep each tag leading to file changes that need to be checked in, and only have a template placeholders as the committed thing in the repo
Contributor
There was a problem hiding this comment.
Sounds good, thank you.
rvagg
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is done by running
go generatebeforego build.This hopefully addresses the request in #644 in a minimally invasive way.