-
Notifications
You must be signed in to change notification settings - Fork 6
Remove protobufjs in favor of protons-runtime #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
v1rtl
wants to merge
35
commits into
ipld:main
Choose a base branch
from
v1rtl:remove-protobufjs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 23 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
bbe7cdc
feat: move from protobufjs to protobuf-es
v1rtl 4d331d6
chore: remove mocha because of weird esm error and use node --test
v1rtl 729d2c5
chore: fix some of the tests
v1rtl 863de21
fix all undefined errors in tests
v1rtl 38bbe2a
Merge branch 'main' of https://github.com/ipld/js-unixfs into remove-…
v1rtl f5064c7
fill in some default data
v1rtl 6d0583c
switch to proto3
v1rtl b6f3772
fix 3 unit tests
v1rtl 0ae878f
make some bits more correct
v1rtl b7e9d34
use protons-runtime instead
v1rtl 13021f2
remove protobuf-es remainders
v1rtl decc353
remove some more from bufbuild
v1rtl d44a8a3
fix
v1rtl 73fc3d3
move proto back to root to lower diffing
v1rtl c074d4f
try to fix ci
v1rtl 1607431
use mocha again
v1rtl 3f4b568
totally will fix mocha
v1rtl 9538944
fix web tests
v1rtl 92bb7e8
fix symlink test
v1rtl 336d329
fix format neunaces tests for files with no content
v1rtl 7350693
fix failing test because of exposed t arg
v1rtl 8afbd2c
remove unused functions
v1rtl 0d95d9e
Merge branch 'main' of https://github.com/ipld/js-unixfs into remove-…
v1rtl e1697dd
Update src/codec.js
v1rtl c289653
move buffer shim to a test dir
v1rtl 2ac02eb
remove unused readable-stream dev dep
v1rtl b8e7978
wip: switch to proto3 (4 tests fail)
v1rtl 45a84f2
mark `NodeType` as optional
v1rtl 090c867
don't use EMPTY_BUFFER where not needed
v1rtl 34ebe9f
upgrade protons and protons-runtime
v1rtl d04df60
remove unused protobufjs-cli
v1rtl 320bd62
remove dead code and increase coverage
v1rtl 6342a0c
test advanced and complex layouts for files
v1rtl eaf94ab
remove more dead code and check fileSize and blockSizes in files layouts
v1rtl c76a2ec
remove unused imports
v1rtl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export { Buffer } from "buffer" | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "name": "gen", | ||
| "version": "1.0.0", | ||
| "license": "MIT", | ||
| "devDependencies": { | ||
| "typescript": "^4.8.4" | ||
| }, | ||
| "type": "module", | ||
| "exports": "./unixfs.js", | ||
| "scripts": { | ||
| "build": "tsc" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "include": ["./unixfs.ts"], | ||
| "exclude": ["node_modules"], | ||
| "compilerOptions": { | ||
| "target": "ES2020", | ||
| "module": "ES2020", | ||
| "skipLibCheck": true, | ||
| "declaration": false, | ||
| "sourceMap": false, | ||
| "noEmit": false, | ||
| "outDir": ".", | ||
| "moduleResolution": "node", | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.