fix: error on decoding 32-bit floats - #64
Merged
Merged
Conversation
rvagg
approved these changes
Jul 17, 2026
rvagg
left a comment
rvagg
left a comment
Member
There was a problem hiding this comment.
I think I might allow these through on both Go and JS, but honestly I don't care about lax floats, the stricter the better with floats I think, there's far too much wriggle room otherwise.
By default, don't allow 32-bit CBOR floats to be decoded. 64-bit is DAG-CBORs only supported float type. This was brought up at #61 (comment) Thanks!
vmx
force-pushed
the
strict-float-decoding
branch
from
July 17, 2026 09:46
e41593f to
2ee95de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, don't allow 32-bit CBOR floats to be decoded. 64-bit is DAG-CBORs only supported float type.
This was brought up at
#61 (comment) Thanks!